[v3-3-test] Guard the backfill dag-runs list query count and tidy test params (#70126) - #70691
Open
github-actions[bot] wants to merge 1 commit into
Open
[v3-3-test] Guard the backfill dag-runs list query count and tidy test params (#70126)#70691github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…t params (#70126) The GET /backfills/{backfill_id}/dag_runs endpoint added in #67381 relies on joinedload to keep its query count constant, but its tests did not assert that, so a change that drops the eager-load could silently reintroduce an N+1. Add an assert_queries_count guard on the happy path (the count stays constant regardless of the number of dag runs). Also let the test client encode the query parameters from a dict instead of hand-building query strings. (cherry picked from commit e3d060b) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GET /backfills/{backfill_id}/dag_runs endpoint added in #67381 relies on
joinedload to keep its query count constant, but its tests did not assert that,
so a change that drops the eager-load could silently reintroduce an N+1. Add an
assert_queries_count guard on the happy path (the count stays constant
regardless of the number of dag runs). Also let the test client encode the query
parameters from a dict instead of hand-building query strings.
(cherry picked from commit e3d060b)
Co-authored-by: Pierre Jeambrun pierrejbrun@gmail.com