[v3-3-test] Fix wtforms-mocking condition (#70811) - #70821
Merged
Conversation
The previous code
"wtforms.StringField" not in sys.modules
always evaluates to True because StringField is not a module, and is
never present in sys.modules even if wtforms IS installed and imported.
Judging from surrounding code, I think the original intention is to only
patch if wtforms is not installed (and thuse a MagicMock was injected in
the previous block). This changes the check to reflect my assumed
intention.
I also tightened the custom ModuleNotFoundError a bit to carry more
useful information.
(cherry picked from commit 445549a)
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
pierrejeambrun
marked this pull request as ready for review
July 31, 2026 14:37
pierrejeambrun
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
July 31, 2026 14:37
pierrejeambrun
approved these changes
Jul 31, 2026
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
The previous code
"wtforms.StringField" not in sys.modules
always evaluates to True because StringField is not a module, and is
never present in sys.modules even if wtforms IS installed and imported.
Judging from surrounding code, I think the original intention is to only
patch if wtforms is not installed (and thuse a MagicMock was injected in
the previous block). This changes the check to reflect my assumed
intention.
I also tightened the custom ModuleNotFoundError a bit to carry more
useful information.
(cherry picked from commit 445549a)
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code
always evaluates to True because StringField is not a module, and is
never present in sys.modules even if wtforms IS installed and imported.
Judging from surrounding code, I think the original intention is to only
patch if wtforms is not installed (and thuse a MagicMock was injected in
the previous block). This changes the check to reflect my assumed
intention.
I also tightened the custom ModuleNotFoundError a bit to carry more
useful information.
(cherry picked from commit 445549a)
Co-authored-by: Tzu-ping Chung uranusjr@gmail.com