Show user display names for triggered runs and HITL responses - #70836
Merged
uranusjr merged 1 commit intoAug 3, 2026
Merged
Conversation
PR apache#70583 added BaseUser.get_display_name so audit-log rows could show a friendly user name instead of the raw login. The triggering-user field on manually triggered Dag runs, backfills and asset materializations, and the HITL responder field, still recorded the raw login and so showed it in the UI. Auth managers that do not override get_display_name fall back to get_name, so only richer users such as FAB change.
pierrejeambrun
marked this pull request as ready for review
July 31, 2026 14:53
pierrejeambrun
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
rawwar and
shubhamraj-git
as code owners
July 31, 2026 14:53
Member
Author
Before
After
|
amoghrajesh
approved these changes
Aug 3, 2026
Contributor
|
Looks simple enough. |
uranusjr
approved these changes
Aug 3, 2026
Member
|
Do we want to backport this? I feel it’s not necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #70583, which added
BaseUser.get_display_nameand used it so audit-log rows show a friendly user name instead of the raw login.Several other user-facing fields still recorded
get_name()(the raw login):triggering_user_nameon manually triggered Dag runs, backfills, and asset materializations — shown in the Dag Runs table and the Run header.responded_by) — shown in the HITL table and response form.These now use
get_display_name()too, so what the user sees is consistent with the audit log. For auth managers that don't overrideget_display_name(Simple, Keycloak) it falls back toget_name, so their behavior is unchanged; FAB users get their full name.The edge3 worker maintenance-comment site (
get_name()embedded in a comment string) is intentionally left out and will be a separate follow-up: that provider can run against an older core without theget_display_nameinterface, so it needs ahasattr(user, "get_display_name")compatibility guard.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines