Re-tidy the lang-SDK Go example against the upstream go-sdk - #70928
Merged
Conversation
The K8S Lang-SDK job fails on every commit here: the bundle is packed against upstream main's go-sdk, but go_example's committed go.sum was tidied against this branch's go-sdk, and the two dependency graphs have diverged. Go refuses to build on that drift. The cherry-pick of apache#70824 landed without the re-tidy step and its tests, so main builds cleanly and this branch does not.
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl and
vatsrahul1001
as code owners
August 1, 2026 21:20
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubernetes tests / K8S Lang-SDK:3.10-v1.30.13fails on every commit onv3-3-test(e.g. #70912, #70908), so it blocks every PR against the branch.
_lang_sdk_build_go_bundlepacksgo_exampleagainst upstream main's go-sdk, butgo_example's committedgo.sumwas tidied against this branch's go-sdk. Once the twodependency graphs diverge Go refuses to build:
Reproduced locally by assembling the same scratch workspace CI builds (upstream main's
go-sdk+ this branch'sgo_example);go mod tidyreconciles three indirect pins(
x/net,x/sys,x/text, where main is ahead) and the bundle then packs cleanly.mainalready carries this fix — the cherry-pick of #70824 landed without the re-tidy stepand its two test assertions. This restores both, leaving
_lang_sdk_build_go_bundleandtest_kubernetes_lang_sdk_commands.pybyte-identical tomain.Only the throwaway scratch copy is tidied; the committed
go.sumis untouched and staysguarded by the
check-go-example-mod-tidyprek hook.Both restored assertions fail without the source change and pass with it (18 passed).
Dev/CI tooling only, not user-facing, so no newsfragment.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines