Skip to content

Add SRV DNS record support to HTTP Operator - #70960

Open
gtxu wants to merge 4 commits into
apache:mainfrom
gtxu:http-srv-dns-support
Open

Add SRV DNS record support to HTTP Operator#70960
gtxu wants to merge 4 commits into
apache:mainfrom
gtxu:http-srv-dns-support

Conversation

@gtxu

@gtxu gtxu commented Aug 3, 2026

Copy link
Copy Markdown

This pull request allows an HTTP connection resolve its target host and port from a DNS SRV record instead of a fixed host/port, so it can talk to services published via SRV-based service discovery(ie. AWS Service Discovery for ECS).

This changes introduces dnspython as an optional dependency to keep the core HTTP provider lightweight. To prevent DNS query flooding, a TTL cache mechanism is implemented.

  • Implemented soft dependency via the srv extra.

  • Built RFC 2782 compliant failover (lowest priority tier filtering and random target selection).

  • Added concurrency-safe TTL caching (srv_cache_ttl) using asyncio.Lock to prevent cache stampedes in asynchronous contexts.

  • Exposed srv_lookup and srv_cache_ttl configuration directly in the Airflow Connection UI via custom form widgets.

closes: #9186


Was generative AI tooling used to co-author this PR?
  • Yes - Claude Sonnet 5

Generated-by: Claude Sonnet 5 following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg

boring-cyborg Bot commented Aug 3, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@gtxu
gtxu force-pushed the http-srv-dns-support branch 2 times, most recently from fa9502b to ff4e96a Compare August 3, 2026 20:47
@gtxu
gtxu marked this pull request as ready for review August 3, 2026 20:47
@gtxu
gtxu force-pushed the http-srv-dns-support branch 2 times, most recently from 0a99776 to 07f26a6 Compare August 4, 2026 03:23

@aaron-y-chen aaron-y-chen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙂

Comment thread providers/http/src/airflow/providers/http/hooks/http.py Outdated
@gtxu
gtxu force-pushed the http-srv-dns-support branch 3 times, most recently from 634914d to 09cda3c Compare August 5, 2026 18:55

@omkar-foss omkar-foss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me overall. Newly added tests are looking well-covered, would be nice if someone could initiate the ci checks in this PR so we can see them run and pass.

PS: I'm not a maintainer, my review is non-binding. Just trying to help out :)

@gtxu
gtxu force-pushed the http-srv-dns-support branch 2 times, most recently from e959fc5 to dd5042c Compare August 12, 2026 05:10
@gtxu

gtxu commented Aug 12, 2026

Copy link
Copy Markdown
Author

Found out the root cause CI failures (3/3 runs) targeting TestHttpAsyncHookSrvLookup::test_run_resolves_srv_record.
The test was failing with a real network query (dns.resolver.NoAnswer), bypassing the mock, yet consistently passing in local environments.

In Python 3.10(CI Env), mock.patch uses _dot_lookup (which calls getattr), meaning it successfully patched the stale attribute on the dns package. When the hook subsequently executed import dns.asyncresolver, it found no entry in sys.modules, loaded a fresh real module, and bypassed the mock entirely.

Python 3.12 uses pkgutil.resolve_name, which performs a real import and self-heals, explaining why the test failure is not identified in my local test.

Added a stable_dns_import fixture for both SRV test classes.

This fixture re-registers the submodules:

importlib.import_module("dns.resolver")
importlib.import_module("dns.asyncresolver")

Drafted-by: Claude Code (Sonnet 5); reviewed by @gtxu

Comment thread providers/http/docs/connections/http.rst Outdated
@gtxu
gtxu force-pushed the http-srv-dns-support branch from 2dcf401 to d146a1f Compare August 13, 2026 00:10
@gtxu
gtxu requested a review from ashb August 13, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SRV DNS record support to http connections

4 participants