Spark: Fix missing space in YARN waitAppCompletion error message - #71055
Open
onlyarnav wants to merge 1 commit into
Open
Spark: Fix missing space in YARN waitAppCompletion error message#71055onlyarnav wants to merge 1 commit into
onlyarnav wants to merge 1 commit into
Conversation
Fix implicit string literal concatenation missing a space between 'conflicts' and 'with' in _YarnSparkSubmitBackend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
_YarnSparkSubmitBackend.submit_job(airflow/providers/apache/spark/operators/spark_submit.py), implicit string literal concatenation across lines lacked a trailing space after "conflicts":"spark.yarn.submit.waitAppCompletion=true cannot be set for cluster mode as it conflicts" "with the need to exit spark-submit immediately to persist the application ID for tracking. "
This rendered as
"conflictswith"in the exception message raised to users.This PR adds the missing space so the error message correctly formats as
"conflicts with the need", and updates the corresponding unit test regex intest_spark_submit.pyto assert the formatted string.Related Issues / Context
Follow-up to #68679.
fixes: #71053