Skip to content

Only refuse team-scoped-looking env var ids when multi_team is on - #71079

Merged
potiuk merged 2 commits into
apache:mainfrom
astronomer:teams-check-core
Aug 5, 2026
Merged

Only refuse team-scoped-looking env var ids when multi_team is on#71079
potiuk merged 2 commits into
apache:mainfrom
astronomer:teams-check-core

Conversation

@amoghrajesh

Copy link
Copy Markdown
Contributor

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Same issue as #71078 but for core airflow env backend.

Summary

  • EnvironmentVariablesBackend refuses to resolve any connection or variable id containing the team separator (___), to avoid colliding with a team-scoped environment variable name.
  • That refusal ran unconditionally, even when [core] multi_team is off -- the default. Without multi-team mode, no team-scoped variable can be defined, so the refusal had no ambiguity to guard against and only produced false positives on ordinary ids.

Gating with the multi team config to guard it.


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@potiuk
potiuk merged commit a058f7d into apache:main Aug 5, 2026
78 checks passed
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 5, 2026
…am is on (apache#71079)

* Only refuse team-scoped-looking env var ids when multi_team is on

* Only refuse team-scoped-looking env var ids when multi_team is on
(cherry picked from commit a058f7d)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 5, 2026
…am is on (apache#71079)

* Only refuse team-scoped-looking env var ids when multi_team is on

* Only refuse team-scoped-looking env var ids when multi_team is on
(cherry picked from commit a058f7d)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants