Document how clearing tasks works with task state store on durable operators - #71358
Conversation
uros-b
left a comment
There was a problem hiding this comment.
@amoghrajesh Please note that the PR title got cut-off mid word:
Document how clearing tasks works with task state store on durable operators
jason810496
left a comment
There was a problem hiding this comment.
How about waiting for #71356 (review) discussion first before landing into each providers.
Additionally, would it make sense to add the prek script with <-- auto sync by ... --> like marker to prevent drift?
|
agree we can wait for another PR to be merged. but I don't think we really need a prek hook for that. overkill IMO |
|
Yeah I think we don't need a prek hook - seems like an overkill. |
Thanks for letting me know, thanks! |
jason810496
left a comment
There was a problem hiding this comment.
How about mentioning something like "we're only able to reconnect back to the external job if it's deferred task deferrable=True, see more in ... <link to the core docs that we just settled in #71356 >"?
|
Added. Each doc now says explicitly that reconnect-on-clear is most reliable for deferred tasks (deferrable=True), since clearing an actively-polling synchronous task can cancel the job via on_kill before the next attempt gets a chance to reconnect. Links to the caveat in core-concepts/resumable-tasks (from #71356). |
|
@jason810496 @uros-b I added the reference and suggestion as suggested. Can you take a look? |
Was generative AI tooling used to co-author this PR?
Same as #71356 but for providers.
Clearing a task whose external job already succeeded returns without resubmitting, since state store rows survive a clear. Rather than duplicate the explanation per operator, each doc gets a one-line pointer to the shared core-concepts writeup, plus the
clear_on_successsetting that restores "clearing always resubmits."Touches
SparkSubmitOperator,RedshiftDataOperator,DatabricksRunNowOperator,DatabricksSubmitRunOperator, andSnowflakeSqlApiOperator.{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.