Pre-populate a suggested partition key when manually triggering cron-partitioned Dags - #71392
Draft
Lee-W wants to merge 1 commit into
Draft
Pre-populate a suggested partition key when manually triggering cron-partitioned Dags#71392Lee-W wants to merge 1 commit into
Lee-W wants to merge 1 commit into
Conversation
Lee-W
force-pushed
the
suggest-partition-key-on-trigger
branch
4 times, most recently
from
August 12, 2026 11:18
c74c887 to
589276a
Compare
…partitioned Dags Manually triggering a Dag whose timetable is CronPartitionTimetable leaves the Partition Key field blank. If the user submits without typing one, the Dag run is created unpartitioned and any downstream asset-partition-aware Dag can never be satisfied by it. Add a new Timetable.suggest_partition_key(now) hook, overridden by CronPartitionTimetable to suggest the most recently elapsed partition tick. Thread the suggestion through a new suggested_partition_key field on DAGResponse to pre-populate the trigger form's Partition Key field. The field stays editable and still submits null if the user clears it. The Dags list view builds its payload by reading every DAGResponse field off a bare DagModel, so a field that only the single-Dag endpoints supply has to be declared as such or that endpoint fails with AttributeError. The trigger form applies the suggestion again whenever a newer one arrives, because a response served from cache can name a partition that has since elapsed.
Lee-W
force-pushed
the
suggest-partition-key-on-trigger
branch
from
August 12, 2026 13:52
589276a to
eed1aa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually triggering a Dag whose timetable is CronPartitionTimetable leaves the Partition Key field blank. If the user submits without typing one, the Dag run is created unpartitioned and any downstream asset-partition-aware Dag can never be satisfied by it.
Add a new Timetable.suggest_partition_key(now) hook, overridden by CronPartitionTimetable to suggest the most recently elapsed partition tick. Thread the suggestion through a new suggested_partition_key field on DAGResponse to pre-populate the trigger form's Partition Key field. The field stays editable and still submits null if the user clears it.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.