fix: add ssl_ciphers CLI option for API server - #71432
Conversation
|
Closing this as part of a cleanup of a large batch of PRs opened in quick succession from this account. 18 PRs have been opened here in the past two weeks and none have merged. Several show signs of being generated and submitted without review: #71432 and #71433 are the same change across the same five files, opened two minutes apart, and several titles carry a leaked agent identifier that other contributors already flagged as garbled text on #70629 and #71322. Airflow is maintained by volunteers. Every PR costs reviewer time and CI capacity, so a high volume of unvetted submissions has a real cost to the project. You are welcome to keep contributing. Please open one change at a time, run it locally against the tests, and read the contributors' guide before submitting. If you think a specific change here is correct, comment with the reasoning and a maintainer can reopen it. |
Summary
Adds the missing
--ssl-ciphersCLI option to the Airflow API server, allowing users to configure the SSL cipher suite for both Uvicorn and Gunicorn backends.Changes
CLI config (
airflow-core/src/airflow/cli/cli_config.py): AddedARG_SSL_CIPHERS(--ssl-ciphers) argument and registered it in the api-server command arg list.API server command (
airflow-core/src/airflow/cli/commands/api_server_command.py):ssl_ciphersto uvicorn asssl_cipherskwargssl_ciphersto Gunicorn viacreate_gunicorn_appGunicorn app (
airflow-core/src/airflow/api_fastapi/gunicorn_app.py): Addedssl_ciphersparameter tocreate_gunicorn_app()and setoptions["ciphers"]when provided.Config template (
airflow-core/src/airflow/config_templates/config.yml): Addedssl_ciphersconfig option under the[api]section.Tests (
airflow-core/tests/unit/cli/commands/test_api_server_command.py): Updated expected kwargs to includessl_ciphers=None.Related issue
Closes #71426 — Missing SSL options for API Server [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT]