Skip to content

Stop presenting multi-team tagged metrics as an exhaustive list - #71523

Merged
o-nikolas merged 1 commit into
apache:mainfrom
aws-mwaa:ramitkataria/multi-team-callback-metric-name
Aug 13, 2026
Merged

Stop presenting multi-team tagged metrics as an exhaustive list#71523
o-nikolas merged 1 commit into
apache:mainfrom
aws-mwaa:ramitkataria/multi-team-callback-metric-name

Conversation

@ramitkataria

@ramitkataria ramitkataria commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

The list read as an authoritative enumeration of every metric carrying a team_name tag, so it drifts out of date as metrics change and misleads anyone building dashboards or alerts from it. A stale entry naming a callback failure counter that is never emitted is the symptom that surfaced the problem.

Readers need to know which areas of Airflow carry the tag; the emission sites in the source are the right authority for individual metric names.


Was generative AI tooling used to co-author this PR?
  • Yes (Claude Opus 5)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@o-nikolas o-nikolas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never really loved this being an authoritative and exhaustive source of the metrics which are team-ified. I think the best place is to just look at the code (easy task for any modern agent). We're just going to be stuck updating these docs constantly as they inevitably become out of date as changes happen. Can we just this to just mention a handful of metrics and then a "..., etc."? Or maybe have a Note that says this isn't an exhaustive list?

The list read as an authoritative enumeration of every metric carrying a
team_name tag, so it drifts out of date as metrics change and misleads anyone
building dashboards or alerts from it. A stale entry naming a callback failure
counter that is never emitted is the symptom that surfaced the problem.

Readers need to know which areas of Airflow carry the tag; the emission sites
in the source are the right authority for individual metric names.
@ramitkataria
ramitkataria force-pushed the ramitkataria/multi-team-callback-metric-name branch from 48a5ba6 to 3424a53 Compare August 13, 2026 01:27
@ramitkataria ramitkataria changed the title Fix incorrect callback failure metric name in multi-team docs Stop presenting multi-team tagged metrics as an exhaustive list Aug 13, 2026
@ramitkataria

Copy link
Copy Markdown
Contributor Author

That makes sense. I've updated the PR

@o-nikolas
o-nikolas merged commit 812c7d8 into apache:main Aug 13, 2026
70 checks passed
@o-nikolas
o-nikolas deleted the ramitkataria/multi-team-callback-metric-name branch August 13, 2026 20:47
dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
…he#71523)

The list read as an authoritative enumeration of every metric carrying a
team_name tag, so it drifts out of date as metrics change and misleads anyone
building dashboards or alerts from it. A stale entry naming a callback failure
counter that is never emitted is the symptom that surfaced the problem.

Readers need to know which areas of Airflow carry the tag; the emission sites
in the source are the right authority for individual metric names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants