Skip to content

Make airflow/migrations/env.py Pylint Compatible #9670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Jul 8, 2020
Merged

Make airflow/migrations/env.py Pylint Compatible #9670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/migrations/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from alembic import context

from airflow import models, settings
from airflow.models.serialized_dag import SerializedDagModel # noqa
from airflow.models.serialized_dag import SerializedDagModel # pylint: disable=unused-import # noqa

@kaxil kaxil Jul 5, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potiuk Do you remember if we need this import there?

I remember you were moving the imports for the migrations to work, so I am not sure

@potiuk potiuk Jul 5, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not here (it was where reset method was) but I think for migrations it's also needed - in order to generate migration diffs for all the model objects.

@potiuk potiuk Jul 5, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly we even need to add more here (from airflow.utils.db). Possibly one place where we import one modes?:

from airflow.models import (  # noqa: F401 # pylint: disable=unused-import
    DAG, XCOM_RETURN_KEY, BaseOperator, BaseOperatorLink, Connection, DagBag, DagModel, DagPickle, DagRun,
    DagTag, Log, Pool, SkipMixin, SlaMiss, TaskFail, TaskInstance, TaskReschedule, Variable, XCom,
)
# We need to add this model manually to get reset working well
# noinspection PyUnresolvedReferences
from airflow.models.serialized_dag import SerializedDagModel  # noqa: F401  # pylint: disable=unused-import

@kaxil kaxil Jul 6, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be ok, we only needed that in db.resetdb. Ran it locally, didn't error

#7381
https://github.com/apache/airflow/pull/6938/files

@kaxil kaxil Jul 7, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT @potiuk ?

@potiuk potiuk Jul 7, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaxil kaxil Jul 7, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, can you approve it :D



def include_object(_, name, type_, *args):
Expand Down
2 changes: 1 addition & 1 deletion pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ ignored-classes=optparse.Values,thread._local,_thread._local,sqlalchemy.orm.scop
# (useful for modules/projects where namespaces are manipulated during runtime
# and thus existing member attributes cannot be deduced by static analysis. It
# supports qualified module names, as well as Unix pattern matching.
ignored-modules=alembic.op
ignored-modules=alembic.op,alembic.context

# Show a hint with possible names when a member name was not found. The aspect
# of finding the hint is based on edit distance.
Expand Down
1 change: 0 additions & 1 deletion scripts/ci/pylint_todo.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
./airflow/configuration.py
./airflow/logging_config.py
./airflow/macros/hive.py
./airflow/migrations/env.py
./airflow/models/crypto.py
./airflow/models/dag.py
./airflow/models/dagbag.py
Expand Down