[AMBARI-22872] Register/Confirm Host for modular deployment.#225
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Not a fan of "Rows per page" as it is a bit too literal. "Items" wasn't much better. I would rather see this string be contextual, like "Hosts per page" or whatever the table rows represent.
There was a problem hiding this comment.
Currently the way this is implemented is using App.PaginationView which doesn't allow this customization, so this has to be generic (there could be tables not having any hosts but processes or services or components instead). We can of course change the way view is implemented to make it more customizable but that requires a larger effort and the change would need to be reflected in other parts of the code. We can leave it for now, and can re-visit it later if there is a more pressing need.
There was a problem hiding this comment.
We really need to standardize the styles around the icons in the Actions columns of tables. That's why I introduced the ".icon-button" and associated styles. Doesn't need to be done in this pull request, but we should restyle these for consistency whenever we come across them. Overly specific style rules like this shouldn't be necessary very often.
There was a problem hiding this comment.
Thanks for pointing this out. Got duplicated while merging.
There was a problem hiding this comment.
I know that the mockups show specific labels on the next buttons, but I'm not sure it's a great idea. For one thing, it makes it harder to reorder steps if needed. Also, we don't do the same thing to the back buttons. Finally, we have a very prominent navigation menu on the left, so it's not like the user won't know where they're going. If we really want the buttons to be this way, it would be better to make them automatically adjust the labels based on the next/previous steps. I can bring this up with Subhrajit.
There was a problem hiding this comment.
Not sure what to do here. Will wait to hear back from Subhrajit then.
ishanbha
force-pushed
the
AMBARI-22872-branch-feature-AMBARI-14714-ui
branch
from
c2a0eb1 to
be0990f
Compare
…h-feature-AMBARI-14714-ui
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
…h-feature-AMBARI-14714-ui
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
5 participants
What changes were proposed in this pull request?
UI changes for the Register/Confirm Hosts step for Mpack work
How was this patch tested?
20392 passing (22s)
125 pending