AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3#3781
Merged
Conversation
Resolves "is" and "is not" compiler warnings introduced in python 3.8 when comparing literals. See https://discuss.python.org/t/demoting-the-is-operator-to-avoid-an-identity-crisis/86 for more details.
Contributor
|
The changes look good overall. @JiaLiangC you also want to take a look? |
Contributor
|
@virajjasani I encountered a similar warning message, and this modification looks good. |
Contributor
|
Thanks @Danori, I encountered these warnings too. It appears in python 3.8+. |
Contributor
|
Thank you @JiaLiangC @Danori @wenwj0, merging the PR |
Contributor
Author
|
Oh looks like my commit didn't follow the typical conventions; would you guys like me to amend my commit before we merge? |
Contributor
Contributor
|
Looks like my bad, i did squash & merge, not sure why the PR title was not retained. Sorry about that. |
Contributor
|
If you want to create the PR again, let me revert the commit first and then you can re-create the PR. |
virajjasani
added a commit
that referenced
this pull request
Apr 18, 2024
virajjasani
pushed a commit
that referenced
this pull request
Apr 18, 2024
Contributor
|
Alright, I have taken care of this, no worries. Thank you everyone, once again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Resolves "is" and "is not" compiler warnings introduced in python 3.8 when comparing literals.
See https://discuss.python.org/t/demoting-the-is-operator-to-avoid-an-identity-crisis/86 for more details.
Before:
After:
How was this patch tested?
Manual test / validation in custom Rocky Linux 9 docker environment (planning on contributing support for Redhat 9 in the near future)
Please review Ambari Contributing Guide before opening a pull request.