[AMBARI-23006] upgrade admin#471
Merged
jonathan-hurley merged 15 commits intoMar 1, 2018
Merged
Conversation
added 14 commits
February 2, 2018 16:44
…ck end. Includes DashRow and Timeline controls.
…-admin # Conflicts: # ambari-web/app/styles/application.less # ambari-web/app/views.js
…pache/ambari into AMBARI-23006_upgrade-admin
|
Refer to this link for build results (access rights to CI server needed): |
atkach
reviewed
Feb 28, 2018
| headerClass: Em.View.extend({ | ||
| templateName: require('templates/main/admin/serviceGroups/upgradeStatusHeader'), | ||
| step: Em.computed.alias('parentView.upgrade.currentStep'), | ||
| isPrerequisitesActive: function () { |
Contributor
There was a problem hiding this comment.
For simple properties you can use Em.computed.equal(dependentKey, value).
atkach
reviewed
Feb 28, 2018
|
|
||
| return false; | ||
| }.property('step'), | ||
| isPrerequisitesComplete: function () { |
Contributor
There was a problem hiding this comment.
Here Em.computed.or('isInstallActive', 'isInstallComplete')
atkach
reviewed
Feb 28, 2018
|
|
||
| var App = require('app'); | ||
|
|
||
| App.MpackComparison = Ember.View.extend({ |
Contributor
There was a problem hiding this comment.
If view doesn't contain any logic you insert template directly:
{{template "templates/your-template"}}
Author
|
@atkach OK, I have addressed your comments. |
|
Refer to this link for build results (access rights to CI server needed): |
atkach
approved these changes
Mar 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the "Upgrade" part of the admin screen that shows the state of the saved upgrade plan and progress of the upgrade process, including action history log.
How was this patch tested?
All tests passing:
20402 passing (31s)
46 pending