Skip to content

[AMBARI-22764] NN HA wizard is broken due to recent commit for config… #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atkach merged 1 commit into from
Jan 11, 2018
Merged

[AMBARI-22764] NN HA wizard is broken due to recent commit for config… #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ambari-web/app/templates/common/configs/service_config.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@
{{view App.SpinnerView}}
{{/if}}

<div class="configs-save-panel" {{bindAttr class="view.showSavePanel::hidden"}}>
<div {{bindAttr class="view.showSavePanel::hidden :configs-save-panel"}}>
<div class="pull-right">
<button class="btn btn-default" {{action doCancel target="controller"}}
{{bindAttr disabled="view.isDiscardDisabled"}}>
Expand Down
2 changes: 1 addition & 1 deletion ambari-web/app/views/common/configs/service_configs_by_category_view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ App.ServiceConfigsByCategoryView = Em.View.extend(App.Persist, App.ConfigOverrid
*/
isShowBlock: function () {
const isFilterEmpty = this.get('controller.filter') === '';
const isFilterActive = this.get('mainView.columns').someProperty('selected');
const isFilterActive = this.get('mainView.columns') && this.get('mainView.columns').someProperty('selected');
const isCustomPropertiesCategory = this.get('category.customCanAddProperty');
const isCompareMode = this.get('controller.isCompareMode');
const hasFilteredAdvancedConfigs = this.get('categoryConfigs').filter(function (config) {
Expand Down