[AMORO-4217] Clean up invalid code and parameters left over from the snapshot-expiring refactoring#4226
Merged
zhoujinsong merged 4 commits intoMay 20, 2026
Conversation
github-actions
Bot
added
type:docs
Removed unnecessary blank line in JacksonUtilTest.
zhangwl9
force-pushed
the
AMORO-clean-snapshot_expire-dev
branch
from
c90a31b to
448950d
Compare
zhoujinsong
approved these changes
May 20, 2026
zhoujinsong
left a comment
zhoujinsong
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Thanks a lot for the work!
j1wonpark
pushed a commit
to j1wonpark/amoro
that referenced
this pull request
Jun 4, 2026
upstream 11커밋 동기화: AMS startup crash fix(apache#4224 AMORO-4223), snapshot/data/orphan/dangling cleaning ProcessFactory 리팩터(apache#4226/apache#4218/apache#4209/apache#4214), JUnit5 마이그레이션(apache#4199/apache#4204) 등. 사내 고유 JP CI(ts-ci-jp.yml: JDK11, tag-base) 보존.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #4217.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation