Fix build for ld.bfd in anticipation of setting up CI#10
Merged
Conversation
The driver manager and drivers define the same symbols. Normally,
this means that if the driver manager loads a driver, and then the
driver attempts to resolve ADBC functions (e.g. to populate the
driver function pointer table), the dynamic linker will actually
resolve the driver manager's symbols, which is a problem.
Previously, we used __attribute__(visibility("protected")). But
it turns out ld.bfd doesn't like this, complaining about an invalid
relocation (ld.mold worked fine). The driver manager could use
RTLD_DEEPBIND, but this doesn't work with ASan. We could also try
-Bsymbolic(-functions) too, but this is additional work for the
build process. So instead, just take the tedious-but-easy route
and define each symbol twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #7.
The driver manager and drivers define the same symbols. Normally,
this means that if the driver manager loads a driver, and then the
driver attempts to resolve ADBC functions (e.g. to populate the
driver function pointer table), the dynamic linker will actually
resolve the driver manager's symbols, which is a problem.
Previously, we used attribute(visibility("protected")). But
it turns out ld.bfd doesn't like this, complaining about an invalid
relocation (ld.mold worked fine). The driver manager could use
RTLD_DEEPBIND, but this doesn't work with ASan. We could also try
-Bsymbolic(-functions) too, but this is additional work for the
build process. So instead, just take the tedious-but-easy route
and define each symbol twice.