Skip to content

Add warning for Arrow.ArrowTypes.registertype!#96

Merged
quinnj merged 1 commit intoapache:mainfrom
ericphanson:patch-2
Jan 5, 2021
Merged

Add warning for Arrow.ArrowTypes.registertype!#96
quinnj merged 1 commit intoapache:mainfrom
ericphanson:patch-2

Conversation

@ericphanson
Copy link
Member

Closes #87. I think I got the admonition syntax right, but I didn't test it locally.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #96 (28789b1) into main (f9db51a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files          23       23           
  Lines        2673     2673           
=======================================
  Hits         2237     2237           
  Misses        436      436           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9db51a...28789b1. Read the comment docs.

jrevels added a commit to beacon-biosignals/Onda.jl that referenced this pull request Jan 5, 2021
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@quinnj quinnj merged commit f92592c into apache:main Jan 5, 2021
@ericphanson ericphanson deleted the patch-2 branch January 5, 2021 10:20
@ericphanson ericphanson mentioned this pull request Jan 5, 2021
tanmaykm pushed a commit to tanmaykm/arrow-julia that referenced this pull request Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

downstream packages need to put Arrow.ArrowTypes.registertype! statements in __init__

2 participants