Skip to content

Add from_iter_values for binary array#1188

Merged
alamb merged 1 commit into
masterfrom
add-from-iter-values-for-bin-array
Jan 17, 2022
Merged

Add from_iter_values for binary array#1188
alamb merged 1 commit into
masterfrom
add-from-iter-values-for-bin-array

Conversation

@jimexist

@jimexist jimexist commented Jan 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

note the implementation is mirrored from string array

Are there any user-facing changes?

added API for generic binary array

@jimexist jimexist mentioned this pull request Jan 17, 2022
Merged
@codecov-commenter

codecov-commenter commented Jan 17, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.64%. Comparing base (e45d118) to head (4ae1e50).

Files with missing lines Patch % Lines
arrow/src/array/array_binary.rs 92.30% 2 Missing ⚠️
arrow/src/array/array_string.rs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1188   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files         173      173           
  Lines       50865    50874    +9     
=======================================
+ Hits        42037    42047   +10     
+ Misses       8828     8827    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Jan 17, 2022
alamb
alamb approved these changes Jan 17, 2022
View reviewed changes

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimexist

Comment thread arrow/src/array/array_binary.rs
}

// iterator size hint may not be correct so compute the actual number of offsets
assert!(!offsets.is_empty()); // wrote at least one

@alamb alamb Jan 17, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit d9f574e into master Jan 17, 2022
@jimexist jimexist deleted the add-from-iter-values-for-bin-array branch January 17, 2022 15:40
@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Jan 20, 2022
@alamb alamb changed the title add from_iter_values for binary array Add from_iter_values for binary array Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimexist @codecov-commenter @alamb