add parquet-fromcsv (#1)#1798
Merged
Merged
Conversation
add command line tool for convert csv to parquet.
Codecov Report
@@ Coverage Diff @@
## master #1798 +/- ##
==========================================
- Coverage 83.53% 83.48% -0.06%
==========================================
Files 200 201 +1
Lines 56798 56838 +40
==========================================
+ Hits 47449 47451 +2
- Misses 9349 9387 +38
Continue to review full report at Codecov.
|
Contributor
|
Sorry for the delay, I keep meaning to review this, will endeavor to do so tomorrow |
tustvold
approved these changes
Jun 8, 2022
tustvold
left a comment
tustvold
left a comment
Contributor
There was a problem hiding this comment.
This looks really nice, only some relatively minor nits.
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
tustvold
reviewed
Jun 8, 2022
tustvold
reviewed
Jun 9, 2022
tustvold
approved these changes
Jun 10, 2022
Contributor
|
Wonderful, thank you for this 🏅 The MIRI failures are unrelated to this PR so going to get this in 😄 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add command line tool for convert csv to parquet.
Which issue does this PR close?
Closes #1797 .
Rationale for this change
What changes are included in this PR?
add parquet-fromcsv CLI,
Are there any user-facing changes?