Skip to content

Split up arrow::array::builder module (#1843)#1879

Merged
alamb merged 2 commits into
apache:masterfrom
DaltonModlin:apache#1843
Jun 17, 2022
Merged

Split up arrow::array::builder module (#1843)#1879
alamb merged 2 commits into
apache:masterfrom
DaltonModlin:apache#1843

Conversation

@DaltonModlin

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #1843

Rationale for this change

Currently, arrow::array::builder contains 12 distinct builders; breaking the builders into submodules makes test coverage and functional differences more obvious.

Are there any user-facing changes?

No

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Jun 15, 2022

@tustvold tustvold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 👍, I plan to go through this this evening unless someone else gets there first. Left some minor comments from a cursory run through.

Edit: CI appears to be unhappy

Comment thread arrow/src/array/builder/mod.rs Outdated
Comment thread arrow/src/array/builder/mod.rs Outdated

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @DaltonModlin

this PR appears to have a conflict -- could you possible resolve it and I will then merge it in?

Thanks!

- Removed old builder.rs
- Added missing licensing header to builder submodules
- Updated builder submodule imports and exports
- Updated array mod file builder imports and exports
@codecov-commenter

codecov-commenter commented Jun 17, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.97648% with 227 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.47%. Comparing base (2e3d8dd) to head (c7c6cb7).

Files with missing lines Patch % Lines
arrow/src/array/builder/decimal_builder.rs 69.18% 49 Missing ⚠️
arrow/src/array/builder/struct_builder.rs 77.47% 41 Missing ⚠️
arrow/src/array/builder/union_builder.rs 76.99% 26 Missing ⚠️
arrow/src/array/builder/primitive_builder.rs 91.88% 19 Missing ⚠️
arrow/src/array/builder/map_builder.rs 81.63% 18 Missing ⚠️
arrow/src/array/builder/boolean_builder.rs 75.75% 16 Missing ⚠️
arrow/src/array/builder/fixed_size_list_builder.rs 87.61% 13 Missing ⚠️
.../src/array/builder/primitive_dictionary_builder.rs 78.18% 12 Missing ⚠️
arrow/src/array/builder/generic_list_builder.rs 96.65% 10 Missing ⚠️
arrow/src/array/builder/buffer_builder.rs 92.80% 9 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1879      +/-   ##
==========================================
- Coverage   83.48%   83.47%   -0.02%     
==========================================
  Files         203      214      +11     
  Lines       57141    57163      +22     
==========================================
+ Hits        47705    47717      +12     
- Misses       9436     9446      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alamb alamb merged commit 0a8deed into apache:master Jun 17, 2022
@alamb

alamb commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Thanks again @DaltonModlin

@DaltonModlin DaltonModlin deleted the apache#1843 branch June 17, 2022 20:05
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Jun 23, 2022
tustvold added a commit that referenced this pull request Jun 23, 2022
…1928)

* Fix merge conflicts from (#1879)

* Split out of decimal_builder (#1843)

* Fix RAT

* Format

* Restore (#1842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split up arrow::array::builder module

4 participants