Fix subtraction underflow when sorting string arrays with many nulls#285
Merged
nevi-me merged 1 commit intoMay 13, 2021
Merged
Conversation
medwards
force-pushed
the
fix_sort_with_limit_string_arrays
branch
from
ce2a822 to
2ebd0a6
Compare
Contributor
|
@alamb @jorgecarleitao This is a bugfix for an issue we had with sorting strings or dictionary encoded strings in our system, would be great to get a quick review |
jorgecarleitao
approved these changes
May 11, 2021
jorgecarleitao
left a comment
jorgecarleitao
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks a lot.
If I understand, this was similar to the bug in primitive types and it has the same resolution here. 👍
Contributor
Author
That's correct. |
nevi-me
approved these changes
May 11, 2021
nevi-me
left a comment
nevi-me
left a comment
Contributor
There was a problem hiding this comment.
Didn't review in a lot of detail, but I follow the approach
Contributor
|
Thank you @medwards |
Contributor
|
Done @medwards @jhorstmann |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
String arrays, boolean arrays, arrays of lists, and more follow a different code path than primitive arrays so updating to match #236
Are there any user-facing changes?
No.