Fix undefined behavior in FFI and enable MIRI checks on CI#323
Merged
Conversation
- Fix UB due to aliasing - Enable MIRI in CI for most tests in arrow crate Signed-off-by: roee88 <roee88@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
=======================================
Coverage 82.52% 82.52%
=======================================
Files 162 162
Lines 44007 44007
=======================================
+ Hits 36316 36317 +1
+ Misses 7691 7690 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jorgecarleitao
approved these changes
May 21, 2021
jorgecarleitao
left a comment
jorgecarleitao
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks a lot, @roee88 !
alamb
reviewed
May 21, 2021
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
I also think this looks great -- it would be cool to file a follow on ticket to remove the remaining MIRI flagged issues but this seems like a great step forward to me
| cargo miri test || true | ||
| # Currently only the arrow crate is tested with miri | ||
| # IO related tests and some unsupported tests are skipped | ||
| cargo miri test -p arrow -- --skip csv --skip ipc --skip json |
alamb
approved these changes
May 21, 2021
8 tasks
alamb
changed the title
This was referenced May 24, 2021
This was referenced Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix UB in FFI due to violation of aliasing rules
Which issue does this PR close?
Closes #322.
What changes are included in this PR?
test result: ok. 584 passed; 0 failed; 10 ignored; 0 measured; 102 filtered outSpecifically, the CI is changed to run miri test against the arrow crate (only) while skipping some tests:
#[cfg_attr(miri, ignore)]with a code comment that indicates why it's disabledThe above was required because otherwise the CI would be stuck forever (e.g., in the
test_can_cast_typestest). This wasn't the case so far because the FFI issue failed the run. I suggest to track enabling more tests in #227.Are there any user-facing changes?
No