refactor lexico sort for future code reuse#423
Conversation
c9e23b1 to
efef737
Compare
jorgecarleitao
left a comment
There was a problem hiding this comment.
Thanks @jimexist ! Ready to go in my opinion
not sure what i can do about the docker build failures |
efef737 to
a0ba084
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 82.64% 82.64% -0.01%
==========================================
Files 162 162
Lines 44542 44549 +7
==========================================
+ Hits 36813 36817 +4
- Misses 7729 7732 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seems like rebasing just solved this issue |
I think that causes the tests to get re-run and thus if the error was due to some network glitch or something it will be solved by the re-execution |
Which issue does this PR close?
Re #428
Rationale for this change
the logic to sort a list of columns lexicographically given sort options was previously embedded within
lexsortbut this pull request changes to pull that part out to a generic struct for future code reuse.This change is used in #424
What changes are included in this PR?
Are there any user-facing changes?