Return NotFound for directories in Head and Get (#4230) #4231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
May 16, 2023
| let file = File::open(path).map_err(|e| { | ||
| if e.kind() == std::io::ErrorKind::NotFound { | ||
| Error::NotFound { | ||
| let file = match File::open(path).and_then(|f| Ok((f.metadata()?, f))) { |
Contributor
Author
There was a problem hiding this comment.
This is potentially slightly unfortunate, in that we require an additional syscall, but I couldn't find a mechanism to only open files
tustvold
force-pushed
the
mask-directories
branch
from
43cca27 to
3ff5dda
Compare
kdbrooks
reviewed
May 16, 2023
object_store/src/azure/client.rs
Outdated
| Err(crate::Error::NotFound { | ||
| path: path.to_string(), | ||
| source: format!( | ||
| "Not a directory, got x-ms-resource-type: {}", |
Contributor
Author
There was a problem hiding this comment.
Oops lol
Edit: fixed, good spot
wjones127
approved these changes
May 17, 2023
alamb
pushed a commit
to alamb/arrow-rs
that referenced
this pull request
Mar 20, 2025
* Return NotFound for directories in Head and Get (#4230) * Fix webdav * Fix error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes apache/arrow-rs-object-store#165
Rationale for this change
I spent a non-trivial amount of time helping diagnose an issue with apache/datafusion#6183 that boiled down to a head request being made instead of a list request, because the
ListingTableUrldidn't end with a/. Normally this would have returned a 404 NotFound which would have made the issue easy to identify, however, because it was an Azure hierarchical namespace this didn't occur.LocalFileSystem also runs into a similar issue.
What changes are included in this PR?
Are there any user-facing changes?
LocalFileSystem and MicrosoftAzure will no longer return directories for get and head requests