Cherry Pick: Add Decimal to CsvWriter and improve debug display (#406)#465
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## active_release #465 +/- ##
===============================================
Coverage 82.69% 82.70%
===============================================
Files 163 163
Lines 44762 44782 +20
===============================================
+ Hits 37016 37036 +20
Misses 7746 7746
Continue to review full report at Codecov.
|
Contributor
Author
|
Needs #475 then rebase to get a clean CI run |
* Add Decimal to CsvWriter and improve debug display * Measure CSV writer instead of file and data creation * Re-use decimal formatting
d812a5a to
60495c2
Compare
This was referenced Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual Cherry pick of fb45112 from #406
I didn't bring the changes to benches as that caused a conflict
FYI @alippai