Skip to content

Cherry Pick: Add Decimal to CsvWriter and improve debug display (#406)#465

Merged
alamb merged 1 commit into
active_releasefrom
cherry_pick_fb451125
Jun 21, 2021
Merged

Cherry Pick: Add Decimal to CsvWriter and improve debug display (#406)#465
alamb merged 1 commit into
active_releasefrom
cherry_pick_fb451125

Conversation

@alamb

@alamb alamb commented Jun 19, 2021

Copy link
Copy Markdown
Contributor

Manual Cherry pick of fb45112 from #406
I didn't bring the changes to benches as that caused a conflict

FYI @alippai

@codecov-commenter

codecov-commenter commented Jun 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #465 (34e00d1) into active_release (153085f) will increase coverage by 0.00%.
The diff coverage is 89.28%.

❗ Current head 34e00d1 differs from pull request most recent head 60495c2. Consider uploading reports for the commit 60495c2 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           active_release     #465   +/-   ##
===============================================
  Coverage           82.69%   82.70%           
===============================================
  Files                 163      163           
  Lines               44762    44782   +20     
===============================================
+ Hits                37016    37036   +20     
  Misses               7746     7746           
Impacted Files Coverage Δ
arrow/src/util/display.rs 32.46% <60.00%> (+2.73%) ⬆️
arrow/src/array/array_binary.rs 90.13% <92.85%> (-0.03%) ⬇️
arrow/src/csv/writer.rs 83.15% <100.00%> (+0.50%) ⬆️
parquet/src/encodings/encoding.rs 95.04% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153085f...60495c2. Read the comment docs.

@alamb

alamb commented Jun 20, 2021

Copy link
Copy Markdown
Contributor Author

Needs #475 then rebase to get a clean CI run

* Add Decimal to CsvWriter and improve debug display

* Measure CSV writer instead of file and data creation

* Re-use decimal formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants