fix clippy warnings for rust 1.53#470
Merged
Merged
Conversation
added 2 commits
June 19, 2021 20:51
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 82.65% 82.66%
=======================================
Files 165 165
Lines 45563 45550 -13
=======================================
- Hits 37662 37653 -9
+ Misses 7901 7897 -4 ☔ View full report in Codecov by Sentry. |
jorgecarleitao
approved these changes
Jun 19, 2021
jorgecarleitao
left a comment
jorgecarleitao
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks a lot for the cleanup 👍
Dandandan
approved these changes
Jun 19, 2021
nevi-me
approved these changes
Jun 19, 2021
Contributor
|
Thanks, you beat me to this :) |
Contributor
|
Thank you @jimexist |
alamb
pushed a commit
to alamb/arrow-rs
that referenced
this pull request
Jun 20, 2021
* fix clippy warnings for rust 1.53 * update readme
alamb
added a commit
that referenced
this pull request
Jun 20, 2021
* fix clippy warnings for rust 1.53 (#470) * fix clippy warnings for rust 1.53 * update readme * Fix up Co-authored-by: Jiayu Liu <Jimexist@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
fix clippy warnings for rust 1.53
Closes #467
Rationale for this change
fixing lint changes introduced by rust 1.53 so that
masterbranch can be mergeable againWhat changes are included in this PR?
to_*naming convention lint warnings.collectthanfromAre there any user-facing changes?
no user facing changes