Validate output of MIRI is successful on CI#578
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
=======================================
Coverage 82.46% 82.46%
=======================================
Files 167 167
Lines 46205 46205
=======================================
Hits 38101 38101
Misses 8104 8104
Continue to review full report at Codecov.
|
alamb
commented
Jul 21, 2021
adc189d to
2ed25c7
Compare
Contributor
Author
|
FYI @jorgecarleitao @nevi-me and @roee88 -- I am merging this PR in so that we do not allow MIRI failures in again on CI 🎉 |
alamb
added a commit
that referenced
this pull request
Jul 25, 2021
alamb
added a commit
that referenced
this pull request
Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #581
Rationale for this change
We started running MIRI again in #421, but while discussing with @jorgecarleitao
on jorgecarleitao/arrow2#209, it turned out that we were still
||trueing the output (aka not validating that MIRA was running cleanly)What changes are included in this PR?
Check output of MIRI return
Are there any user-facing changes?
No