Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
6e8c864
bench
kazuyukitanimura Aug 22, 2024
a81ba56
fix: Optimize set_bits
kazuyukitanimura Aug 22, 2024
57634f2
clippy
kazuyukitanimura Aug 23, 2024
32ff203
clippyj
kazuyukitanimura Aug 23, 2024
f94f312
miri
kazuyukitanimura Aug 23, 2024
e9cd77a
fix: Optimize set_bits
kazuyukitanimura Aug 23, 2024
842c2b1
fix: Optimize set_bits
kazuyukitanimura Aug 23, 2024
06de184
fix: Optimize set_bits
kazuyukitanimura Aug 23, 2024
03b0db8
fix: Optimize set_bits
kazuyukitanimura Aug 23, 2024
7faa5f3
fix: Optimize set_bits
kazuyukitanimura Aug 23, 2024
e3d812d
fix: Optimize set_bits
kazuyukitanimura Aug 23, 2024
13dec63
fix: Optimize set_bits
kazuyukitanimura Aug 23, 2024
68cdaf2
fix: Optimize set_bits
kazuyukitanimura Aug 23, 2024
1e9de38
miri
kazuyukitanimura Aug 24, 2024
f1e1bbd
miri
kazuyukitanimura Aug 24, 2024
f294663
miri
kazuyukitanimura Aug 24, 2024
39719c4
miri
kazuyukitanimura Aug 24, 2024
9fbb87d
miri
kazuyukitanimura Aug 24, 2024
74b9d80
miri
kazuyukitanimura Aug 24, 2024
25c309e
miri
kazuyukitanimura Aug 24, 2024
7905330
miri
kazuyukitanimura Aug 24, 2024
6dd9771
miri
kazuyukitanimura Aug 24, 2024
0e956cc
miri
kazuyukitanimura Aug 24, 2024
272ecbb
miri
kazuyukitanimura Aug 24, 2024
08ebf20
address review comments
kazuyukitanimura Sep 3, 2024
d751a7f
address review comments
kazuyukitanimura Sep 3, 2024
ef2864f
address review comments
kazuyukitanimura Sep 4, 2024
e69cf9a
Revert "address review comments"
kazuyukitanimura Sep 4, 2024
b5f8bca
address review comments
kazuyukitanimura Sep 5, 2024
9c15417
address review comments
kazuyukitanimura Sep 5, 2024
533381a
address review comments
kazuyukitanimura Sep 5, 2024
dca9ab8
address review comments
kazuyukitanimura Sep 5, 2024
7f3c3fb
address review comments
kazuyukitanimura Sep 5, 2024
6ccedd2
address review comments
kazuyukitanimura Sep 6, 2024
ff2f3ca
address review comments
kazuyukitanimura Sep 6, 2024
fb46cb0
address review comments
kazuyukitanimura Sep 6, 2024
3fd5e3e
address review comments
kazuyukitanimura Sep 6, 2024
be3076e
address review comments
kazuyukitanimura Sep 6, 2024
58868c1
address review comments
kazuyukitanimura Sep 6, 2024
a15db14
address review comments
kazuyukitanimura Sep 6, 2024
fefafa7
Revert "address review comments"
kazuyukitanimura Sep 6, 2024
d8c3f08
address review comments
kazuyukitanimura Sep 6, 2024
cc5ec2b
address review comments
kazuyukitanimura Sep 6, 2024
4c39dc8
address review comments
kazuyukitanimura Sep 9, 2024
f4789be
address review comments
kazuyukitanimura Sep 9, 2024
59fd805
address review comments
kazuyukitanimura Sep 10, 2024
7d81076
address review comments
kazuyukitanimura Sep 13, 2024
f185a19
address review comments
kazuyukitanimura Sep 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Optimize set_bits
  • Loading branch information
kazuyukitanimura committed Aug 23, 2024
commit 68cdaf24b1b3be772fb48217634e97105875bc09
2 changes: 1 addition & 1 deletion arrow-buffer/src/util/bit_mask.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ fn set_upto_64bits(
}
} else if write_shift == 0 {
let len = 64 - 8; // 56 bits so that write_shift == 0 for the next iteration
let chunk = (chunk >> read_shift) | 0x00FFFFFFFFFFFFFF; // 56 bits mask
let chunk = (chunk >> read_shift) & 0x00FFFFFFFFFFFFFF; // 56 bits mask
let null_count = len - chunk.count_ones() as usize;
write_u64_bytes(write_data, write_byte, chunk);
(null_count, len)
Expand Down