Skip to content

Add get_bit to BooleanBufferBuilder#693

Merged
Dandandan merged 2 commits into
apache:masterfrom
boazberman:master
Aug 15, 2021
Merged

Add get_bit to BooleanBufferBuilder#693
Dandandan merged 2 commits into
apache:masterfrom
boazberman:master

Conversation

@boazberman

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Ref apache/datafusion#342
Ref apache/datafusion#240

Rationale for this change

Described in the DataFusion issue. To make BooleanBufferBuilder useable as a bit vector within DataFusion code I needed this api exposed as well.

What changes are included in this PR?

Are there any user-facing changes?

@codecov-commenter

codecov-commenter commented Aug 14, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.44%. Comparing base (1a5c26b) to head (eb2ff69).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files         168      168           
  Lines       47347    47365   +18     
=======================================
+ Hits        39033    39052   +19     
+ Misses       8314     8313    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dandandan Dandandan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The tests look good as well

cc @jorgecarleitao @nevi-me

@boazberman

Copy link
Copy Markdown
Contributor Author

How many approvers does one need to get a pr merged?

@Dandandan Dandandan merged commit 0b7ac79 into apache:master Aug 15, 2021
@Dandandan

Copy link
Copy Markdown
Contributor

How many approvers does one need to get a pr merged?

We don't have a minimum reviewers requirement. The PRs will be merged after some common sense judgement, based on the complexity of the changes and giving other reviewers time to review and comment.

As the change is small and not really controversial I just merged it
Thanks again! 🎉

@alamb

alamb commented Aug 16, 2021

Copy link
Copy Markdown
Contributor

I plan to backport this change to 5.3.0 (eta in about two weeks time)

alamb pushed a commit that referenced this pull request Aug 19, 2021
* Add get_bit to BooleanBufferBuilder

* fix clippy
@alamb

alamb commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

Backport in #699. I plan to make 5.3.0 release candidate around Aug 27

alamb added a commit that referenced this pull request Aug 20, 2021
* Add get_bit to BooleanBufferBuilder

* fix clippy

Co-authored-by: Boaz <berman.boaz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants