-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add Extensions to object store PutOptions
#7213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Extensions to object store PutOptions
#7213
Conversation
| ) -> Result<PutResult> { | ||
| let PutOptions { | ||
| mode, | ||
| // not supported by GCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tustvold can you check if this is correct or an oversight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC GCP doesn't have a notion of tags as separate from general metadata
See #4999
tustvold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW there is also PutMultipartOpts
Ah, that struct doesn't end in Will file an extra PR for that. |
Done in #7214. |
Follow-up to apache#7170.
Change the `ObjectStore` core trait to have a single, extensible copy operation. This helps apache#385 and apache#297. Also adds extensions similar to apache/arrow-rs#7170 and apache/arrow-rs#7213 . Closes apache#116.
Change the `ObjectStore` core trait to have a single, extensible copy operation. This helps #385 and #297. Also adds extensions similar to apache/arrow-rs#7170 and apache/arrow-rs#7213 . Closes #116.
Change the `ObjectStore` core trait to have a single, extensible rename operation. This helps apache#385 and apache#297. Also adds extensions similar to apache/arrow-rs#7170 and apache/arrow-rs#7213 . Also see apache#548 -- which did something similar for `copy`.
Change the `ObjectStore` core trait to have a single, extensible rename operation. This helps apache#385 and apache#297. Also adds extensions similar to apache/arrow-rs#7170 and apache/arrow-rs#7213 . Also see apache#548 -- which did something similar for `copy`.
Change the `ObjectStore` core trait to have a single, extensible rename operation. This helps #385 and #297. Also adds extensions similar to apache/arrow-rs#7170 and apache/arrow-rs#7213 . Also see #548 -- which did something similar for `copy`.
Which issue does this PR close?
-
Rationale for this change
Follow-up to #7170.
See #7170 (comment) .
What changes are included in this PR?
PutOptions::extensions.Are there any user-facing changes?
Breaking: New field.