Skip to content

Conversation

@crepererum
Copy link
Contributor

Which issue does this PR close?

-

Rationale for this change

Follow-up to #7170.

See #7170 (comment) .

What changes are included in this PR?

PutOptions::extensions.

Are there any user-facing changes?

Breaking: New field.

@crepererum crepererum added api-change Changes to the arrow API object-store labels Feb 27, 2025
) -> Result<PutResult> {
let PutOptions {
mode,
// not supported by GCP
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tustvold can you check if this is correct or an oversight?

Copy link
Contributor

@tustvold tustvold Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC GCP doesn't have a notion of tags as separate from general metadata

See #4999

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW there is also PutMultipartOpts

@crepererum
Copy link
Contributor Author

FWIW there is also PutMultipartOpts

Ah, that struct doesn't end in Options 🤷

Will file an extra PR for that.

@crepererum crepererum merged commit 9384224 into apache:main Feb 27, 2025
14 checks passed
@crepererum
Copy link
Contributor Author

Will file an extra PR for that.

Done in #7214.

alamb pushed a commit to alamb/arrow-rs that referenced this pull request Mar 20, 2025
crepererum added a commit to crepererum/arrow-rs-object-store that referenced this pull request Nov 20, 2025
Change the `ObjectStore` core trait to have a single, extensible copy
operation. This helps apache#385 and apache#297.

Also adds extensions similar to 
apache/arrow-rs#7170
and
apache/arrow-rs#7213 .

Closes apache#116.
alamb pushed a commit to apache/arrow-rs-object-store that referenced this pull request Nov 25, 2025
Change the `ObjectStore` core trait to have a single, extensible copy
operation. This helps #385 and #297.

Also adds extensions similar to 
apache/arrow-rs#7170
and
apache/arrow-rs#7213 .

Closes #116.
crepererum added a commit to crepererum/arrow-rs-object-store that referenced this pull request Nov 26, 2025
Change the `ObjectStore` core trait to have a single, extensible rename
operation. This helps apache#385 and apache#297.

Also adds extensions similar to 
apache/arrow-rs#7170
and
apache/arrow-rs#7213 .

Also see apache#548 -- which did something similar for `copy`.
crepererum added a commit to crepererum/arrow-rs-object-store that referenced this pull request Nov 26, 2025
Change the `ObjectStore` core trait to have a single, extensible rename
operation. This helps apache#385 and apache#297.

Also adds extensions similar to 
apache/arrow-rs#7170
and
apache/arrow-rs#7213 .

Also see apache#548 -- which did something similar for `copy`.
crepererum added a commit to apache/arrow-rs-object-store that referenced this pull request Dec 4, 2025
Change the `ObjectStore` core trait to have a single, extensible rename
operation. This helps #385 and #297.

Also adds extensions similar to 
apache/arrow-rs#7170
and
apache/arrow-rs#7213 .

Also see #548 -- which did something similar for `copy`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to the arrow API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants