Updated arrow-pyarrow to use pyo3 0.27, updated deprecated code warnings#8773
Merged
Conversation
# Conflicts: # arrow-pyarrow/src/lib.rs
kylebarron
reviewed
Nov 3, 2025
kylebarron
approved these changes
Nov 3, 2025
mbrobbel
added
api-change
mbrobbel
reviewed
Nov 4, 2025
Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com>
Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com>
Contributor
|
Now that main is open for breaking API changes, I have updated this PR and will merge it when CI passes |
Contributor
|
Thanks again @hntd187 @mbrobbel and @kylebarron |
Merged
Contributor
|
Somehow all the CI checks passed and yet clippy now fails on main after merging this PR I have a fix ready: |
Jefffrey
pushed a commit
that referenced
this pull request
Jan 10, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes #NNN. # Rationale for this change Clippy is failiing on main after merging cfba3cc - #8773 Example: https://github.com/apache/arrow-rs/actions/runs/20865325961/job/59954918027 ``` error: deref which would be done by auto-deref --> arrow-pyarrow/src/lib.rs:636:39 | 636 | Ok(Self(T::from_pyarrow_bound(&*value)?)) | ^^^^^^^ help: try: `&value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#explicit_auto_deref = note: `-D clippy::explicit-auto-deref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::explicit_auto_deref)]` ``` # What changes are included in this PR? Apply clippy fix # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
Dandandan
pushed a commit
to Dandandan/arrow-rs
that referenced
this pull request
Jan 15, 2026
…ngs (apache#8773) # Which issue does this PR close? No issue, I'm aware of. Just updates pyo3 to 0.27 so delta-rs can start looking at variant adoption. # Rationale for this change There is a long list of dependencies for arrow 57 to be supported in enough places such that delta-rs can start to reliably build against them. Updating pyo3 puts arrow in line with the other arrow based dependencies. # Are these changes tested? We typically require tests for all PRs in order to: Since this is a good amount of unsafe, and I'm on Windows (which I'd imagine is not the common path) I'd like to see the CI/CD run just to make sure everything looks good. If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? # Are there any user-facing changes? Just that a dependency is now a later version --------- Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Dandandan
pushed a commit
to Dandandan/arrow-rs
that referenced
this pull request
Jan 15, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes #NNN. # Rationale for this change Clippy is failiing on main after merging apache@cfba3cc - apache#8773 Example: https://github.com/apache/arrow-rs/actions/runs/20865325961/job/59954918027 ``` error: deref which would be done by auto-deref --> arrow-pyarrow/src/lib.rs:636:39 | 636 | Ok(Self(T::from_pyarrow_bound(&*value)?)) | ^^^^^^^ help: try: `&value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#explicit_auto_deref = note: `-D clippy::explicit-auto-deref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::explicit_auto_deref)]` ``` # What changes are included in this PR? Apply clippy fix # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue, I'm aware of. Just updates pyo3 to 0.27 so delta-rs can start looking at variant adoption.
Rationale for this change
There is a long list of dependencies for arrow 57 to be supported in enough places such that delta-rs can start to reliably build against them. Updating pyo3 puts arrow in line with the other arrow based dependencies.
Are these changes tested?
We typically require tests for all PRs in order to:
Since this is a good amount of unsafe, and I'm on Windows (which I'd imagine is not the common path) I'd like to see the CI/CD run just to make sure everything looks good.
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
Are there any user-facing changes?
Just that a dependency is now a later version