Allow more encryption algorithms #9203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xanderbailey
left a comment
xanderbailey
left a comment
There was a problem hiding this comment.
When I exposed quote style here I exported the underlying QuoteStyle is that something we might want to do here also for Algorithm?
Author
|
Thank you for the review, I took a look at your PR. You made Do you mean you'd like to make |
mbutrovich
reviewed
Jan 27, 2026
| use crate::errors::Result; | ||
| use crate::file::metadata::HeapSize; | ||
| use ring::aead::{AES_128_GCM, Aad, LessSafeKey, NonceSequence, UnboundKey}; | ||
| use ring::aead::{AES_128_GCM, Aad, LessSafeKey, NonceSequence, UnboundKey, Algorithm}; |
Contributor
There was a problem hiding this comment.
Did this have cargo fmt run on it? The order looks off to me.
mbutrovich
reviewed
Jan 27, 2026
| keys: DecryptionKeys, | ||
| aad_prefix: Option<Vec<u8>>, | ||
| footer_signature_verification: bool, | ||
| algorithm: &'static Algorithm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
arrow-rsfor Parquet I/O, I'd like to start supporting AES 256 with this PR.What changes are included in this PR?
new_with_algorithmfunction toRingGcmBlockEncryptorandRingGcmBlockDecryptor, which takes one moreAlgorithmargument.Are these changes tested?
Yes, unit test and on AES-256 encrypted Parquet files.
Are there any user-facing changes?
Yes, added a new API