Implement support for reading CSV files with charsets other than UTF-8#9468
Open
Rafferty97 wants to merge 8 commits intoapache:mainfrom
Open
Implement support for reading CSV files with charsets other than UTF-8#9468Rafferty97 wants to merge 8 commits intoapache:mainfrom
Rafferty97 wants to merge 8 commits intoapache:mainfrom
Conversation
Rafferty97
force-pushed
the
non-utf8-csv2
branch
from
f03a9fa to
648da5a
Compare
…8, via an optional dependency on `encoding_rs` and a corresponding configuration option.
Rafferty97
force-pushed
the
non-utf8-csv2
branch
from
29fd008 to
24aa46b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for reading CSV files with charsets other than UTF-8, via an optional dependency on
encoding_rsand a corresponding configuration option.Which issue does this PR close?
Closes #9465
What changes are included in this PR?
encoding_rscsv-coreAre these changes tested?
I have written tests that exercise the decoder on windows-1252 and Shift-JIS encoded CSV files, with various batch and buffer sizes to ensure that the various buffering mechanisms are working. I'm fairly confident in the test coverage, but open to suggestions for making the tests more resilient.
Are there any user-facing changes?
The public API is only changed when the new optional feature is enabled, and even then, it's just a new optional configuration parameter.