[R] strptime should return NA (not error) with format mismatch

[asfimport]

base::strptime() returns NA when the value passed to the format argument does not match the string to be parsed. The arrow binding currently errors in the same scenario.

strptime("2022-02-11", format = "%Y-%m-%d")
#> [1] "2022-02-11 GMT"
strptime("2022-02-11", format = "%Y %m-%d")
#> [1] NA

suppressMessages(library(lubridate))
suppressMessages(library(arrow))
suppressMessages(library(dplyr))

df <- tibble(x = "2022-02-11")

df %>% 
  mutate(z = strptime(x, format = "%Y-%m %d"))
#> # A tibble: 1 × 2
#>   x          z     
#>   <chr>      <dttm>
#> 1 2022-02-11 NA

df %>% 
  record_batch() %>% 
  mutate(z = strptime(x, format = "%Y-%m %d")) %>% 
  collect()
#> Error: Invalid: Failed to parse string: '2022-02-11' as a scalar of type timestamp[ms]

Reporter: Dragoș Moldovan-Grünfeld / @dragosmg
Assignee: Dragoș Moldovan-Grünfeld / @dragosmg
Watchers: Rok Mihevc / @rok

Related issues:

• [R] Implement bindings for lubridate's parse_date_time (blocks)
• [C++] Add error handling option to StrptimeOptions (is blocked by)
• [R] Improve as.Date() error message when supplying several tryFormats (is depended upon by)

PRs and other links:

• GitHub Pull Request #12402

_{Note: This issue was originally created as ARROW-15659. Please see the migration documentation for further details.}

[asfimport]

Dragoș Moldovan-Grünfeld / @dragosmg:
This would also allow us to use coalesce() downstream to cycle through several formats, for example, when defining {}parse_date_time(){}.

[asfimport]

Rok Mihevc / @rok:
ARROW-15665 was just solved. We added error_is_null option to Strptime kernel and you probably just want to add tests for it now.

[asfimport]

Dragoș Moldovan-Grünfeld / @dragosmg:
Cool. I had clocked that. Many thanks for the heads-up and for all your work. 

[asfimport]

Jonathan Keane / @jonkeane:
Issue resolved by pull request 12402
#12402