ARROW-12540: [C++] Implementing casting support from date32/date64 to uft8/large_utf8#10870
ARROW-12540: [C++] Implementing casting support from date32/date64 to uft8/large_utf8#10870rommelDB wants to merge 4 commits into
Conversation
…nted the casting support from date32/date64 to uft8/large_utf8
|
@bkietz please, have a look to this PR |
|
Looks like there are some lint failures - you can fix them locally as described at https://arrow.apache.org/docs/developers/cpp/development.html#code-style-linting-and-ci or by commenting |
lidavidm
left a comment
There was a problem hiding this comment.
Thanks for this. I left a comment about the FIXME.
lidavidm
left a comment
There was a problem hiding this comment.
LGTM, thanks! Will merge on green.
|
(Well, if you don't plan on adding more - feel free to mark ready for review) |
Thank you so much David! I will be aware of the CI output. |
|
I think the failures here are flukes (GHA seems to be having a bit of trouble), let's see when the Travis build finishes. |
|
Thanks for doing this! 🙏 In the future, it can be a good idea to grep the source for the Jira issue number to see if there are any TODOs or skipped tests related to the issue. There was one in the R test suite from when the issue was originally reported; I've removed it in #10891. |
Yes, I totally agree with you, thanks for the reminder. |
Changes: