Skip to content

ARROW-14223: [C++] add missing third-party dependency#11320

Closed
coryan wants to merge 1 commit into
apache:masterfrom
coryan:ARROW-14223-add-google-cloud-cpp-to-thirdparty-dependencies
Closed

ARROW-14223: [C++] add missing third-party dependency#11320
coryan wants to merge 1 commit into
apache:masterfrom
coryan:ARROW-14223-add-google-cloud-cpp-to-thirdparty-dependencies

Conversation

@coryan

@coryan coryan commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

In #11268 I neglected to add google_cloud_cpp_storage to the
third-party dependencies.

@github-actions

github-actions Bot commented Oct 5, 2021

Copy link
Copy Markdown

@coryan

coryan commented Oct 5, 2021

Copy link
Copy Markdown
Contributor Author

/FYI @kou

@github-actions

github-actions Bot commented Oct 5, 2021

Copy link
Copy Markdown

⚠️ Ticket has no components in JIRA, make sure you assign one.

@github-actions

github-actions Bot commented Oct 5, 2021

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

In #11268 I neglected to add `google_cloud_cpp_storage` to the
third-party dependencies.
@coryan

coryan commented Oct 5, 2021

Copy link
Copy Markdown
Contributor Author

The build errors are all related to brew being unable to install grpc. Seems unrelated?

@coryan coryan marked this pull request as ready for review October 5, 2021 16:43

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Yes. They are unrelated.

@kou kou closed this in 01ead8b Oct 5, 2021
@coryan coryan deleted the ARROW-14223-add-google-cloud-cpp-to-thirdparty-dependencies branch October 5, 2021 21:25
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
In apache#11268 I neglected to add `google_cloud_cpp_storage` to the
third-party dependencies.

Closes apache#11320 from coryan/ARROW-14223-add-google-cloud-cpp-to-thirdparty-dependencies

Authored-by: Carlos O'Ryan <coryan@google.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants