Skip to content

ARROW-14741: [C++] Add support for RecordBatchReader in CSV writer#11899

Closed
ahadnagy wants to merge 2 commits into
apache:masterfrom
ahadnagy:arrow-14741
Closed

ARROW-14741: [C++] Add support for RecordBatchReader in CSV writer#11899
ahadnagy wants to merge 2 commits into
apache:masterfrom
ahadnagy:arrow-14741

Conversation

@ahadnagy

@ahadnagy ahadnagy commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Dec 8, 2021

Copy link
Copy Markdown

@lidavidm lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

@thisisnic just to confirm, is this the function you were looking to use from the R side?

Comment thread cpp/src/arrow/csv/writer.cc
@thisisnic

Copy link
Copy Markdown
Member

Thanks, this looks good to me.

@thisisnic just to confirm, is this the function you were looking to use from the R side?

Yeah, I think this is what we were after. Thanks!

@lidavidm lidavidm closed this in afa5d95 Dec 8, 2021
@ursabot

ursabot commented Dec 8, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = d3bf0f6 and contender = afa5d95. afa5d95 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants