Skip to content

ARROW-14590: [R] Implement lubridate::week#12097

Closed
AlenkaF wants to merge 3 commits into
apache:masterfrom
AlenkaF:ARROW-14590
Closed

ARROW-14590: [R] Implement lubridate::week#12097
AlenkaF wants to merge 3 commits into
apache:masterfrom
AlenkaF:ARROW-14590

Conversation

@AlenkaF

@AlenkaF AlenkaF commented Jan 7, 2022

Copy link
Copy Markdown
Member

This PR adds the implementation of lubridate::week following the way it is calculated in lubridate.

@github-actions

github-actions Bot commented Jan 7, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14590

@github-actions

github-actions Bot commented Jan 7, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

thisisnic
thisisnic reviewed Jan 7, 2022
View reviewed changes
Comment thread r/tests/testthat/test-dplyr-funcs-datetime.R Outdated
thisisnic
thisisnic reviewed Jan 7, 2022
View reviewed changes
Comment thread r/R/dplyr-funcs-datetime.R Outdated
thisisnic
thisisnic approved these changes Jan 12, 2022
View reviewed changes

@thisisnic thisisnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though let's have @dragosmg and @jonkeane check I'm not missing anything.

@dragosmg

dragosmg commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

LGTM

@thisisnic thisisnic requested a review from jonkeane January 12, 2022 16:26
jonkeane
jonkeane approved these changes Jan 12, 2022
View reviewed changes

@jonkeane jonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thanks! My only comment is basically "Odd, but true! It's too simple to believe!" 😂

Comment thread r/R/dplyr-funcs-datetime.R Outdated
@jonkeane jonkeane closed this in d1fb8e7 Jan 12, 2022
@ursabot

ursabot commented Jan 12, 2022 •
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = b582af1 and contender = d1fb8e7. d1fb8e7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.45% ⬆️0.45%] ursa-i9-9960x
[Failed ⬇️0.31% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@AlenkaF AlenkaF deleted the ARROW-14590 branch January 13, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rok rok rok left review comments
@thisisnic thisisnic thisisnic approved these changes
@jonkeane jonkeane jonkeane approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AlenkaF @dragosmg @ursabot @rok @jonkeane @thisisnic