Skip to content

ARROW-15442: [C++][Python] Skip GDB tests on a non-debug build#12253

Closed
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-15442-gdb-tests-release-build
Closed

ARROW-15442: [C++][Python] Skip GDB tests on a non-debug build#12253
pitrou wants to merge 3 commits into
apache:masterfrom
pitrou:ARROW-15442-gdb-tests-release-build

Conversation

@pitrou

@pitrou pitrou commented Jan 25, 2022

Copy link
Copy Markdown
Member

Even though the GDB extension should theoretically work with a release build, it's difficult to test for, as we can't lookup any variables from the GDB prompt.

Even though the GDB extension should theoretically work with a release build,
it's difficult to test for, as we can't lookup any variables from the GDB prompt.
@pitrou pitrou requested a review from kszucs January 25, 2022 11:59
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@pitrou

pitrou commented Jan 25, 2022

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g python

@github-actions

Copy link
Copy Markdown

Revision: 9c5d859

Submitted crossbow builds: ursacomputing/crossbow @ actions-1483

Task Status
test-conda-python-3.10 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-kartothek-latest Github Actions
test-conda-python-3.7-kartothek-master Github Actions
test-conda-python-3.7-pandas-0.24 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-master Github Actions
test-conda-python-3.9-pandas-master Github Actions
test-conda-python-3.9-spark-master Github Actions
test-debian-11-python-3 Azure
test-fedora-33-python-3 Azure
test-ubuntu-20.04-python-3 Azure

@kszucs

kszucs commented Jan 25, 2022

Copy link
Copy Markdown
Member

Can we remove the PYARROW_TEST_GDB=OFF flags from #12243 once this is merged (presuming a new RC)?

@pitrou

pitrou commented Jan 25, 2022

Copy link
Copy Markdown
Member Author

If these are all non-debug builds, then probably, yes.

@kszucs

kszucs commented Jan 25, 2022

Copy link
Copy Markdown
Member

@github-actions crossbow submit wheel-macos-big-sur-*

@github-actions

Copy link
Copy Markdown

Revision: 88eca5b

Submitted crossbow builds: ursacomputing/crossbow @ actions-1484

Task Status
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions

@kszucs

kszucs commented Jan 25, 2022

Copy link
Copy Markdown
Member

@pitrou shouldn't FileNotFoundError: [Errno 2] No such file or directory: 'gdb' like errors be prevented by the skip here

@pytest.fixture(scope='session')
def gdb():
skip_if_gdb_unavailable()
gdb = GdbSession("-q", python_executable())
?

@pitrou

pitrou commented Jan 25, 2022

Copy link
Copy Markdown
Member Author

@kszucs It should :-(

@pitrou

pitrou commented Jan 25, 2022

Copy link
Copy Markdown
Member Author

Hmm, I get the impression that subprocess may be using two slightly different approaches based on the exact arguments. I'll try to push a fix.

@pitrou

pitrou commented Jan 25, 2022

Copy link
Copy Markdown
Member Author

@kszucs

kszucs commented Jan 25, 2022

Copy link
Copy Markdown
Member

The builds are failing due to an unrelevant issue https://issues.apache.org/jira/browse/ARROW-15453

@kszucs kszucs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Antoine!

@kszucs kszucs closed this in 38d4d77 Jan 25, 2022
@ursabot

ursabot commented Jan 25, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = f6f494e and contender = 38d4d77. 38d4d77 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.52% ⬆️0.13%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@pitrou pitrou deleted the ARROW-15442-gdb-tests-release-build branch January 25, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants