ARROW-14817 [R] Implement bindings for `lubridate::tz()`#12357

Closed

dragosmg wants to merge 35 commits into

apache:masterfrom

dragosmg:lubridate_tz_binding

Commits on Feb 7, 2022

first pass at implementing the binding for `lubridate::tz()`. needs more tests
dragosmg
committed

Commits on Feb 8, 2022

Commits on Feb 16, 2022

some clean up
jonkeane
committed

Commits on Feb 17, 2022

Commits on Feb 19, 2022

first pass at implementing the binding for `lubridate::tz()`. needs more tests

dragosmg
authored and
jonkeane
committed
`tz()` returns `"UTC"` for strings, date and NAs + more tests

dragosmg
authored and
jonkeane
committed
updated NEWS

dragosmg
authored and
jonkeane
committed
fall back to the simpler implementation for `tz()`

dragosmg
authored and
jonkeane
committed
split good and error behaviour in 2 different chunks and use `expect_snapshot()` for the error chunk

dragosmg
authored and
jonkeane
committed
update `tz()` binding to return `NA` when x is `NA`

dragosmg
authored and
jonkeane
committed
update tests to reflect different behaviour for `NA`: arrow returns `NA`, lubridate returns `"UTC"`

dragosmg
authored and
jonkeane
committed
revert to first / original implementation and remove NA propagation unit test

dragosmg
authored and
jonkeane
committed
updated unit tests and snapshots for `tz()`

dragosmg
authored and
jonkeane
committed
update `tz()` with more meaningful error messages

dragosmg
authored and
jonkeane
committed
meaningful names for the test dataframe columns + update snapshots

dragosmg
authored and
jonkeane
committed
simplify the implementation (start with timestamp & error for anything else)

dragosmg
authored and
jonkeane
committed
some clean up
jonkeane
committed
removed snapshot md file

dragosmg
authored and
jonkeane
committed
class extraction

dragosmg
authored and
jonkeane
committed
simplify class extraction once #12447 is merged

dragosmg
authored and
jonkeane
committed
a few test additions|changes
jonkeane
committed

Commits on Feb 21, 2022