Skip to content

ARROW-14094: [C++] add(timestamp, duration) -> timestamp kernel#12378

Closed
rok wants to merge 1 commit into
apache:masterfrom
rok:ARROW-14094
Closed

ARROW-14094: [C++] add(timestamp, duration) -> timestamp kernel#12378
rok wants to merge 1 commit into
apache:masterfrom
rok:ARROW-14094

Conversation

@rok

@rok rok commented Feb 9, 2022

Copy link
Copy Markdown
Member

This is to resolve ARROW-14094.

@github-actions

github-actions Bot commented Feb 9, 2022

Copy link
Copy Markdown

@rok rok changed the title ARROW-14094: [C++] add(timestamp, interval) -> timestamp kernel ARROW-14094: [C++] add(timestamp, duration) -> timestamp kernel Feb 9, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TimestampType and DurationType are both int64_t underneath, is it possible to reuse the existing Exec method? (i.e. does ArithmeticExecFromOp<ScalarBinary, Add>(Type::INT64) work here?)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for ScalarBinaryEqualTypes but not for ScalarBinary as it takes in and out types.
auto exec = ArithmeticExecFromOp<ScalarBinaryEqualTypes, Add>(Type:: INT64); would work.

We could add ArithmeticExecFromOpEqualTypes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think it's not too big a deal then.

@ursabot

ursabot commented Feb 9, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = ec3608c and contender = e31189f. e31189f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.21% ⬆️0.17%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.43% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants