ARROW-5248: [Python] support zoneinfo / dateutil timezones#12421
ARROW-5248: [Python] support zoneinfo / dateutil timezones#12421AlenkaF wants to merge 10 commits into
Conversation
2251387 to
9a1d393
Compare
jorisvandenbossche
left a comment
There was a problem hiding this comment.
This is looking good!
From talking about it:
- Dateutil is optional dependency, and zoneinfo only available from Python 3.9 onwards, so in C++ we (for now) can remove the imports
- The tests will need to add a skip if the package is not available (pytest has a
importorskiphelper that can be used for this)
|
Thanks for reviewing Joris! Currently:
I would leave the handling of There is a CI error with appveyor: |
That looks like an unrelated error (although I don't see it happening on master). I restarted Appveyor to see if that fixes it. |
|
@jorisvandenbossche it looks like the error on Travis isn't connected, so this PR should be ready. |
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
@jorisvandenbossche unrelated Ci issue again, I think ... |
|
Thanks! |
|
Benchmark runs are scheduled for baseline = 094c5ba and contender = 82f8ee3. 82f8ee3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR tries to add support for
zoneinfoanddateutiltimezones.zoneinfozoneinfosupportdateutildateutilsupport