ARROW-14943: [R] Bindings for lubridate's ddays, dhours, dminutes, dmonths, dweeks, dyears#12610
ARROW-14943: [R] Bindings for lubridate's ddays, dhours, dminutes, dmonths, dweeks, dyears#12610AlenkaF wants to merge 9 commits into
Conversation
|
This PR should be updated to use |
|
Left the bindings as were and decided not to use |
paleolimbot
left a comment
paleolimbot
left a comment
There was a problem hiding this comment.
This looks great! Thank you! I just suggested a few changes to match the style of other default arguments in this file.
|
Thanks for reviewing @paleolimbot! I should have noticed I was still in Python land ... 🤦♀️ :) |
|
I added the text to the News.md in #12855. Also got quite some linter corrections when running |
|
All good! I'm new to how development in the arrow R package works, but I think style changes that are outside the scope of the function that is getting added/modified should be a separate PR. I've never used |
|
@AlenkaF there seem to be a few failing tests on windows, are they related to the PR? |
|
Oh, yes, they are related. Will have a look, thanks! |
|
Looking good. One small suggestion. Thanks for tackling the cyclomatic complexity. |
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
dragosmg
left a comment
dragosmg
left a comment
There was a problem hiding this comment.
LGTM. Thanks for all the work! @thisisnic @jonkeane would you mind having a look and merging?
thisisnic
left a comment
thisisnic
left a comment
There was a problem hiding this comment.
Comments resolved, tests pass, and values used match those in lubridate, so looks good to me!
|
Benchmark runs are scheduled for baseline = a63ee07 and contender = 69c28de. 69c28de is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
6 participants
No description provided.