ARROW-16025: [Python][C++] Fix segmentation fault when closing ORCFileWritter#12816
ARROW-16025: [Python][C++] Fix segmentation fault when closing ORCFileWritter#12816raulcd wants to merge 5 commits into
Conversation
…g to close ORCFileWriter without having a writer
… null arrays on ORCWriter
|
As discussed with @jorisvandenbossche I have added a test that was causing a segmentation fault previously as seen on ARROW-15723 which is solved as part of this fix. |
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Looks good, thanks a lot!
|
The failed test is unrelated, merging |
|
Benchmark runs are scheduled for baseline = 5441c4b and contender = ccaef09. ccaef09 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR fixes ARROW-16025 (Calling nonexistent method of pyarrow.orc.ORCWriter causes segfault).
The segmentation fault can be reproduced with the test:
The issue was that closing
ORCFileWriterwithout actually writing was trying to close a null writer (writer_->close();) causing the segmentation fault.