Skip to content

ARROW-16267: [Java] Adding support to compile Java code with JDK 18#13226

Closed
davisusanibar wants to merge 2 commits into
apache:masterfrom
davisusanibar:ARROW-16267
Closed

ARROW-16267: [Java] Adding support to compile Java code with JDK 18#13226
davisusanibar wants to merge 2 commits into
apache:masterfrom
davisusanibar:ARROW-16267

Conversation

@davisusanibar

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

@davisusanibar

Copy link
Copy Markdown
Contributor Author

Please @raulcd / @assignUser your support with this review, thank you in advance.

@assignUser assignUser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job works I had a look at the log and it looks fine to my non-java eyes :) 👍

@lidavidm

Copy link
Copy Markdown
Member

Does GitHub offer a way to just specify "latest" so that we can automatically get 19, 20, ..., etc when they release?

@assignUser

assignUser commented May 24, 2022

Copy link
Copy Markdown
Member

@lidavidm This is a docker issue, as we use some of these for the jobs and they don't have a 3.8.5-openjdk-latest tag. So there is no easy way to keep this up to date automatically. openjdk 19 is slated for release in 9/2022 so maybe we just open a jira with fix-version 10.0.0?

@lidavidm

Copy link
Copy Markdown
Member

Ah, reasonable enough. Just wondering if there was a way to let the infrastructure do it for us.

@amol- amol- closed this in 985c257 May 25, 2022
@ursabot

ursabot commented May 25, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 8bbc695 and contender = 985c257. 985c257 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.23% ⬆️1.87%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.7% ⬆️1.89%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 985c2570 ec2-t3-xlarge-us-east-2
[Failed] 985c2570 test-mac-arm
[Failed] 985c2570 ursa-i9-9960x
[Finished] 985c2570 ursa-thinkcentre-m75q
[Finished] 8bbc6955 ec2-t3-xlarge-us-east-2
[Failed] 8bbc6955 test-mac-arm
[Failed] 8bbc6955 ursa-i9-9960x
[Finished] 8bbc6955 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants