Skip to content

ARROW-18079: [R] Improve efficiency of schema creation to prevent performance regressions#14447

Merged
thisisnic merged 5 commits into
apache:masterfrom
thisisnic:ARROW-18079_improve_performance
Oct 18, 2022
Merged

ARROW-18079: [R] Improve efficiency of schema creation to prevent performance regressions#14447
thisisnic merged 5 commits into
apache:masterfrom
thisisnic:ARROW-18079_improve_performance

Conversation

@thisisnic

@thisisnic thisisnic commented Oct 18, 2022

Copy link
Copy Markdown
Member

No description provided.

@thisisnic

thisisnic commented Oct 18, 2022

Copy link
Copy Markdown
Member Author

@ursabot please benchmark lang=R

@ursabot

ursabot commented Oct 18, 2022 •
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = cd33544 and contender = e5faa53. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Only ['Python'] langs are supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.27%] ursa-i9-9960x
[Skipped ⚠️ Only ['C++', 'Java'] langs are supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e5faa53f test-mac-arm
[Finished] e5faa53f ursa-i9-9960x
[Finished] cd335445 ec2-t3-xlarge-us-east-2
[Failed] cd335445 test-mac-arm
[Finished] cd335445 ursa-i9-9960x
[Finished] cd335445 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@thisisnic thisisnic changed the title ARROW-18079: [R] Improve efficiency of schema creation to prevent performance regressions after ARROW-12105 ARROW-18079: [R] Improve efficiency of schema creation to prevent performance regressions Oct 18, 2022
@thisisnic

thisisnic commented Oct 18, 2022

Copy link
Copy Markdown
Member Author

@ursabot please benchmark lang=R

@ursabot

ursabot commented Oct 18, 2022 •
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = cd33544 and contender = aeeeb03. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Only ['Python'] langs are supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed] ursa-i9-9960x
[Skipped ⚠️ Only ['C++', 'Java'] langs are supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] aeeeb037 test-mac-arm
[Failed] aeeeb037 ursa-i9-9960x
[Finished] cd335445 ec2-t3-xlarge-us-east-2
[Failed] cd335445 test-mac-arm
[Finished] cd335445 ursa-i9-9960x
[Finished] cd335445 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@github-actions

github-actions Bot commented Oct 18, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-18079

@github-actions

github-actions Bot commented Oct 18, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

nealrichardson
nealrichardson approved these changes Oct 18, 2022
View reviewed changes

@nealrichardson nealrichardson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thisisnic thisisnic merged commit e991644 into apache:master Oct 18, 2022
kou pushed a commit that referenced this pull request Oct 20, 2022
@thisisnic @kou
ARROW-18079: [R] Improve efficiency of schema creation to prevent per…
04ccd84 
…formance regressions (#14447)

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thisisnic @ursabot @nealrichardson