Skip to content

GH-34094: [C++] Increase Boost minimum version for clang >= 16 #34100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 6 commits into from
Feb 10, 2023
Merged

GH-34094: [C++] Increase Boost minimum version for clang >= 16 #34100

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b64dc6
increase boost min version for clang >= 16
assignUser Feb 9, 2023
61d842f
don't pin patch version
assignUser Feb 9, 2023
f1e241e
fix lint
assignUser Feb 9, 2023
9430df5
update comment
assignUser Feb 9, 2023
ff86840
Use VERSION_GREATER
kou Feb 10, 2023
24ffa10
Fix style
kou Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,12 @@ macro(build_boost)
set(BOOST_VENDORED TRUE)
endmacro()

if(ARROW_BUILD_TESTS)
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER
15)
# GH-34094 Older versions of Boost use the deprecated std::unary_function in
# boost/container_hash/hash.hpp and support for that was removed in clang 16
set(ARROW_BOOST_REQUIRED_VERSION "1.81")
elseif(ARROW_BUILD_TESTS)
set(ARROW_BOOST_REQUIRED_VERSION "1.64")
else()
set(ARROW_BOOST_REQUIRED_VERSION "1.58")
Expand Down