GH-34865: [C++][Java][Flight RPC] Add Session management messages#34817

Merged

lidavidm merged 195 commits into

apache:mainfrom

indigophox:flight-sql-session-management

Feb 20, 2024

Commits on Feb 15, 2024

Add Session management messages, Location URI path accessors

jduo
authored and
Paul Nienaber
committed
Address PR feedback
Paul Nienaber
committed
Remove non-const references
Paul Nienaber
committed
Add partial (some gaps) ServerSessionMiddleware impl
Paul Nienaber
committed
Initial StartCall impl, etc.
Paul Nienaber
committed
Prelim impl ServerSessionMWFactory locking
Paul Nienaber
committed
Untested initial middleware impl
Paul Nienaber
committed
Rename lock_ and remove duplicitous comments
Paul Nienaber
committed
Make code build
Paul Nienaber
committed
Fix server set-cookie header name
Paul Nienaber
committed
Remove/revert abandoned Location changes
Paul Nienaber
committed
[BUILDS] Move Session messages to Flight PB
Paul Nienaber
committed
Change Proto to use map of Session options
Paul Nienaber
committed
FSQL Client: Use SessionOptions PB Map
Paul Nienaber
committed
FSQL Server: Use SessionOptions PB Map (incomplete?)
Paul Nienaber
committed
[Builds] Fix build errors
Paul Nienaber
committed
[BUILDS] Use visitors to convert SessionOptionValue->Proto
Paul Nienaber
committed
Change to string_view for interfaces
Paul Nienaber
committed
WIP: High-level design review ONLY
Paul Nienaber
committed
WIP: impl *::Deserialize()
Paul Nienaber
committed
WIP: ~finish flight/types.cc & serialization_internal.h
Paul Nienaber
committed
WIP: Update some temporary comments
Paul Nienaber
committed
Impl FromProto(SessionOptionValue...)
Paul Nienaber
committed
Random WIP checkpoint
Paul Nienaber
committed
WIP: Finished serialization_internal.cc ?
Paul Nienaber
committed
WIP: Remove 'Action' prefix from Proto messages
Paul Nienaber
committed
Reduce long Proto nested enum names
Paul Nienaber
committed
Indentation etc.
Paul Nienaber
committed
Update to 'Status' enums in Proto
Paul Nienaber
committed
WIP: More replacement of Result with Status for enums
Paul Nienaber
committed
WIP: Even more replacement of Result with Status for enums
Paul Nienaber
committed
WIP: Even MORE replacement of Result with Status for enums
Paul Nienaber
committed
Formatting & remove erroneous 'static'
Paul Nienaber
committed
Typos
Paul Nienaber
committed
Add new SetSessionOption statuses to Proto
Paul Nienaber
committed
Fixup flight/client.*
Paul Nienaber
committed
Fix name change + remove temporary comments
Paul Nienaber
committed
Move lambda overload helpers around & other cleanup
Paul Nienaber
committed
Fixed all but 1 build error
Paul Nienaber
committed
Fix last build issue
Paul Nienaber
committed
[builds] Remote extraneous comments
Paul Nienaber
committed
[builds] Some PR fixups
Paul Nienaber
committed
[builds] More PR feedback
Paul Nienaber
committed
[builds] More PR feedback
Paul Nienaber
committed
[builds] Fix linter errors
Paul Nienaber
committed
[builds] clang-format
Paul Nienaber
committed
[builds] Add missing include
Paul Nienaber
committed
[builds] Fix clang-format{14,17} differences
Paul Nienaber
committed
[builds] Add missed change from previous
Paul Nienaber
committed
[builds] C++ docs fixup
Paul Nienaber
committed
Add Protobuf docstrings & rename Flight session cookie
Paul Nienaber
committed
[builds] Remove unused Proto import
Paul Nienaber
committed
Fixes for @stevelorddremio's feedback
Paul Nienaber
committed
Revert extraneous linter changes
Paul Nienaber
committed
More PR feedback resolution
Paul Nienaber
committed
More PR feedback
Paul Nienaber
committed
More PR feedback
Paul Nienaber
committed
[builds] More PR fixups
Paul Nienaber
committed
PR feedback
Paul Nienaber
committed
PR feedback
Paul Nienaber
committed
PR feedback
Paul Nienaber
committed
Refactor to facilitate proper make_shared
Paul Nienaber
committed
[builds] Finish refactor to use map.find()
Paul Nienaber
committed
Remove extraneous using namespace
Paul Nienaber
committed
[builds] Factor out session ID generation & remove Boost
Paul Nienaber
committed
[builds] make GetNewSession return std::pair
Paul Nienaber
committed
[builds] Fix argument forwarding for FlightSqlSession::SetSessionOption
Paul Nienaber
committed
[builds] Docs fixup
Paul Nienaber
committed
[builds] move SetSessionOptionsResult status to estensible nested msg
Paul Nienaber
committed
[builds] Remove Result<> wrapper from GetSessionOption
Paul Nienaber
committed
[builds] PR feedback fixups
Paul Nienaber
committed
[builds] PR feedback fixups
Paul Nienaber
committed
[builds] Add virtual default destructor to ServerSessionMiddleware
Paul Nienaber
committed
[builds] Fix CI linter issues.
Paul Nienaber
committed
[builds] Fix abstract subclass ServerSessionMiddleware.
Paul Nienaber
committed
[builds] WHOOPS: Fix tangled/redundant Session ActionTypes
Paul Nienaber
committed
[builds] CI fixups
Paul Nienaber
committed
[builds] Remove redundant branch
Paul Nienaber
committed
[builds] Fix reader/writer locks
Paul Nienaber
committed
[builds] Remove extraneous include
Paul Nienaber
committed
Apply @kou suggestions from code review

authored and
Paul Nienaber
committed
[builds] More @kou feedback integrated
Paul Nienaber
committed
[builds] Fix docs
Paul Nienaber
committed
[builds] PR feedback
Paul Nienaber
committed
[builds] Return {"",NULLPTR} on id generation collision
Paul Nienaber
committed
[builds] linter
Paul Nienaber
committed
[builds] copy to proto repeated string value using iterator
Paul Nienaber
committed
[builds] (partial?) fix for ParseCookieString, pending testing
Paul Nienaber
committed
[builds] fixup
Paul Nienaber
committed
[builds] fixup
Paul Nienaber
committed
[builds] grrrr CI grrrr
Paul Nienaber
committed
[builds] Revert iterator-copy not supported by CI PB libs
Paul Nienaber
committed
Add some testing
Paul Nienaber
committed
oops
Paul Nienaber
committed
grrr linter
Paul Nienaber
committed
grrr linter
Paul Nienaber
committed
grrrr linter
Paul Nienaber
committed
grrrr linter
Paul Nienaber
committed
[builds] Remove extraneous SessionOptions type tests
Paul Nienaber
committed
Typo fix
Paul Nienaber
committed
[Java WIP] Add ActionTypes & some SessionOptionValue types
Paul Nienaber
committed
+some docs
Paul Nienaber
committed
+some docs
Paul Nienaber
committed
+some docs
Paul Nienaber
committed
Add some partially/fully implemented POJO message types
Paul Nienaber
committed
Add method skeleton
Paul Nienaber
committed
WIP: Java: add serde + POJO classes
Paul Nienaber
committed
Fixup
Paul Nienaber
committed
Change SetSessionOptionResult (Proto) to error-only behaviour
Paul Nienaber
committed
[builds] Update C++ to error-only SetSessionOptionsResult
Paul Nienaber
committed
WIP: pseudo-complete Java impl
Paul Nienaber
committed
Fix some checkstyle errors
Paul Nienaber
committed
Fix some more checkstyle errors
Paul Nienaber
committed
checkpoint
Paul Nienaber
committed
checkpoint
Paul Nienaber
committed
checkpoint - should be working but...
Paul Nienaber
committed
[builds] Prelim Java implementation
Paul Nienaber
committed
[builds] Prelim Java implementation
Paul Nienaber
committed
[Java WIP]: Add nullable SessionOptionValue
Paul Nienaber
committed
fixup
Paul Nienaber
committed
[C++][builds] Add unset SessionOptionValue functionality
Paul Nienaber
committed
[C++ builds][Java builds] typos/etc
Paul Nienaber
committed
Add Proto comment re: nullability
Paul Nienaber
committed
[C++][builds] Add braces
Paul Nienaber
committed
[C++][builds] Tiny refactor
Paul Nienaber
committed
Update Proto comments re: HTTP-cookies-or-similar
Paul Nienaber
committed
checkpoint
Paul Nienaber
committed
[Java builds] fixups
Paul Nienaber
committed
[Java builds] Add ServerSessionMiddleware.java
Paul Nienaber
committed
Fixup
Paul Nienaber
committed
checkpoint
Paul Nienaber
committed
checkpoint
Paul Nienaber
committed
checkpoint
Paul Nienaber
committed
checkpoint
Paul Nienaber
committed
[Java builds] Add initial Java integration tests
Paul Nienaber
committed
[C++] clang-format fixups
Paul Nienaber
committed
[C++] clang-format fixup
Paul Nienaber
committed
[Java builds] Add and fix initial working Java integration test
Paul Nienaber
committed
[Java builds] Expand SessionOptionsProducer to facilitate more tests
Paul Nienaber
committed
WIP
Paul Nienaber
committed
checkpoint
Paul Nienaber
committed
[Java builds & passes] fix up integration tests & related code
Paul Nienaber
committed
[Java builds & passes] Fix & add Unicode integration test coverage
Paul Nienaber
committed
[Java builds & passes] ServerSessionMiddleware.CloseSession: expire cookie
Paul Nienaber
committed
[Java builds & passes] Finish Java integration tests
Paul Nienaber
committed
[C++ builds] Factor ServerSessionMiddleware to separate header for testability
Paul Nienaber
committed
[temp] Add dummy C++ unit test
Paul Nienaber
committed
[temp][fixup] Add dummy C++ unit test
Paul Nienaber
committed
[temp][linter fixup] Add dummy C++ unit test
Paul Nienaber
committed
Fix Java build errors & dependencies
Paul Nienaber
committed
[Java builds][C++ builds] Extricate int32 & float
Paul Nienaber
committed
[Java builds][C++ builds] Add NoOpSessionOptionValueVisitor
Paul Nienaber
committed
Test adding Flight C++ unit test
Paul Nienaber
committed
Test #2 adding Flight C++ unit test
Paul Nienaber
committed
Test #3 adding Flight C++ unit test
Paul Nienaber
committed
Test #4 adding Flight C++ unit test
Paul Nienaber
committed
Test #5 adding Flight C++ unit test
Paul Nienaber
committed
[C++ builds] added tautological failure to arrow-flight-sql-test
Paul Nienaber
committed
[C++ builds] Add C++ ServerSessionMiddleware cookie parsing test
Paul Nienaber
committed
[C++ builds] Probably fix Win64 C++ CI build linker error
Paul Nienaber
committed
Revert "[C++ builds] Probably fix Win64 C++ CI build linker error"
Paul Nienaber
committed
[C++ builds] CI linter fixups
Paul Nienaber
committed
[C++ builds] Linter + linker fixups
Paul Nienaber
committed
[Docs] Doc fixup
Paul Nienaber
committed
[C++ builds][Java builds] PR feedback etc
Paul Nienaber
committed
Guessed workaround for opaque CMake linter error
Paul Nienaber
committed
Remove extraneous whitespace in CMakeLists.txt
Paul Nienaber
committed
[C++ builds] checkpoint
Paul Nienaber
committed
[C++ builds] checkpoint
Paul Nienaber
committed
[C++ builds] checkpoint
Paul Nienaber
committed
[C++ builds] checkpoint
Paul Nienaber
committed
[C++ builds] BUG CHECKPOINT
Paul Nienaber
committed
[C++ builds] Add session cookie expiry
Paul Nienaber
committed
[Java builds] Fix NoOpSessionOptionValueVisitor iface
Paul Nienaber
committed
[C++ builds & passes] Bodge around middleware gap
Paul Nienaber
committed
[C++ builds] remove debug spew
Paul Nienaber
committed
[C++ builds & passes] Update middleware & tests
Paul Nienaber
committed
[C++ builds & passes] CI linter fixups
Paul Nienaber
committed
Docstring
Paul Nienaber
committed
Fix CMake lint error
Paul Nienaber
committed
[Java builds & passes] Remove Java integration tests that won't work with broken C++
Paul Nienaber
committed
Add docs
Paul Nienaber
committed
Add session_options to Archery integration testing
Paul Nienaber
committed
Fix imports
Paul Nienaber
committed
Exclude session_options go test
Paul Nienaber
committed
Docs touchup
Paul Nienaber
committed
[Builds & passes] naming consistency fix
Paul Nienaber
committed
[Builds & passes] Docstring fixups
Paul Nienaber
committed
Address PR feedback
Paul Nienaber
committed
Update Protobuf enum comments
Paul Nienaber
committed
Linter fixups & rebase
Paul Nienaber
committed
Factor out addMiddlewareHeaders
Paul Nienaber
committed
Refactor GrpcServiceHandler::GetFlightInfo() to use addMiddlewareHeaders()
Paul Nienaber
committed
PR feedback
Paul Nienaber
committed
PR feedback
Paul Nienaber
committed